fix/ske e2e kubeconfig yaml#234
Merged
Merged
Conversation
The SKE cluster was recreated and its kubeconfig is now published to a new repo-mirrored Vault path by the ICF ske/kubernetes module, which stores it as YAML (yamlencode). The e2e harness used jsondecode, which fails on YAML. Switch to yamldecode, which parses both YAML and JSON (a superset), so the test is robust regardless of the format the kubeconfig secret is provided in. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The e2e provider.tf configures the kubernetes provider by decoding var.ske_kubeconfig, which is now YAML. Follow up to the main.tf change so the provider config also parses the YAML kubeconfig instead of failing jsondecode. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — some checks failingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we supply config to e2e tests changed internally, this PR aligns the hub to this.