Fix airtime calculation in dispatcher#2875
Open
neilalexander wants to merge 1 commit into
Open
Conversation
The `checkSend()` function would always use the `MAX_TRANS_UNIT` to estimate how much airtime is needed before allowing a queued packet to be transmitted instead of the actual queued packet size. This meant that small packets could be forced to wait unfairly before being sent, resulting in unexpected starvation or packet drops under duty cycle limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkSend()function would always use theMAX_TRANS_UNITto estimate how much airtime is needed before allowing a queued packet to be transmitted instead of the actual queued packet size.This meant that small packets could be forced to wait unfairly before being sent, resulting in unexpected starvation or packet drops under duty cycle limits.