Repository navigation
Fix unsigned conversion of negative TX power in CommonRadioPrefs - #3615
Merged
liamcottle merged 2 commits intoOct 27, 2026
Merged
liamcottle merged 2 commits into
liamcottle merged 2 commits into
Conversation
ripplebiz
reviewed
Oct 26, 2026
ripplebiz
left a comment
ripplebiz
left a comment
Member
There was a problem hiding this comment.
overall a 'good catch', but I'd probably drop the unit tests
Author
|
Thanks for the review @ripplebiz — dropped the unit tests as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3318
Problem
NodePrefs::tx_power_dbmandRadioLibWrapper::setTxPower()represent TX power as a signedint8_t(for radios such as SX126x/LR11xx that support negative TX power down to-9 dBm). However,CommonRadioPrefs::getTxPower()andCommonRadioPrefs::setTxPower()(along with their overrides inCommonCLI.handexamples/companion_radio/NodePrefs.h) were declared withuint8_t.As a result, negative TX power values such as
-9 dBmwere converted to247when accessed viaCommonRadioPrefs::getTxPower()(e.g.get txformatting(int32_t) getTxPower()as> 247).Fix
CommonRadioPrefs::getTxPower()andCommonRadioPrefs::setTxPower()and their overrides inCommonCLI::NodePrefs::RadioPrefsandcompanion_radio'sNodePrefs::RadioPrefsfromuint8_ttoint8_t.