Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LR2021 only accepts RF/modulation config commands in STANDBY mode. When
CMD_SET_RADIO_PARAMSarrived over BLE, the radio was in continuous RX, sosetParams()calls were silently rejected with -706 and the new frequencywas never applied. Since the new value was already saved to flash, it only
took effect after a reboot.
Fix: call
standby()before any config command inCustomLR2021Wrapper::setParams()(coverssetPreambleLength()insideupdatePreamble()as well), and log the return code of each call underMESH_DEBUG instead of discarding it. The internal
idle()ofapplySideDetectorConfig()still restarts RX on the new parameters.