Skip to content

fix(screen): drop OTAFIX from the color-screen DFU banner - #94

Merged
jamesarich merged 2 commits into
masterfrom
fix/banner-text-name
Oct 28, 2026
Merged

jamesarich merged 2 commits into
masterfrom
fix/banner-text-name

Conversation

@jamesarich

@jamesarich jamesarich commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Checklist

  • PR title specifically describes the change
  • tools/build_all.py (or CI's board matrix) passes

Description of Change

The color-screen DFU banner still said "meshtastic.org - OTAFIX" on the T096 and T1 and "meshtastic.org - OTAFIX by oltaco" as the TFT default (T114), after the rename. It now reads meshtastic.org, same as the OLED default; oltaco stays credited in the README. Built for all three, the strings in each ELF confirmed.

Summary by CodeRabbit

  • Changes
    • Updated the DFU banner on color-screen boards to display “meshtastic.org” without the additional text.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9fcfad65-2a5c-4f00-acf0-76c426a63327
Commits

Reviewing files that changed from the base of the PR and between 22919a0 and de7ebf6.

Files selected for processing: 5
  • .github/workflows/githubci.yml
  • changelog.md
  • src/boards/heltec_t096/board.h
  • src/boards/heltec_t1/board.h
  • src/screen.c

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The default and two board-specific DFU banner values now read meshtastic.org. The 2.6.0 changelog entry identifies the color-screen banner text. A CI workflow comment now describes the factory-erase UF2 attachment as occurring once in the release job.

Changes: DFU banner text

Layer / File(s) Summary
Banner values and changelog
src/screen.c, src/boards/heltec_t096/board.h, src/boards/heltec_t1/board.h, changelog.md
The default and board-specific banner values no longer include their OTAFIX suffixes. The 2.6.0 changelog entry now specifies the color-screen banner text.

CI workflow comment

Layer / File(s) Summary
Release attachment comment
.github/workflows/githubci.yml
The comment describes factory-erase UF2 attachment by the release job instead of by each build job. It retains the stated race risk from deleting and re-uploading an asset with the same name.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: oltaco, rcarteraz

Merge Risk: Minimal · up to de7eb

The banner updates and workflow comment change are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing “OTAFIX” from the color-screen DFU banner.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the banner bright,
“meshtastic.org” now sits in sight.
The release note records the name,
The workflow comment does the same.
I nibble clover, pleased and spry,
Then hop beneath the moonlit sky.

Comment @coderabbitai help to get the list of available commands.

@jamesarich
jamesarich force-pushed the fix/banner-text-name branch from 7dcd909 to de7ebf6 Compare October 28, 2026 21:12
@jamesarich
jamesarich added this pull request to the merge queue Oct 28, 2026
Merged via the queue into master with commit 9753ecd Oct 28, 2026
26 checks passed
@jamesarich
jamesarich deleted the fix/banner-text-name branch October 28, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant