Repository navigation
fix(screen): drop OTAFIX from the color-screen DFU banner - #94
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Banner values and changelog src/screen.c, src/boards/heltec_t096/board.h, src/boards/heltec_t1/board.h, changelog.md |
The default and board-specific banner values no longer include their OTAFIX suffixes. The 2.6.0 changelog entry now specifies the color-screen banner text. |
CI workflow comment
| Layer / File(s) | Summary |
|---|---|
Release attachment comment .github/workflows/githubci.yml |
The comment describes factory-erase UF2 attachment by the release job instead of by each build job. It retains the stated race risk from deleting and re-uploading an asset with the same name. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: oltaco, rcarteraz
Merge Risk: 
Minimal · up to de7eb
-
The banner updates and workflow comment change are ready to merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the banner bright,
“meshtastic.org” now sits in sight.
The release note records the name,
The workflow comment does the same.
I nibble clover, pleased and spry,
Then hop beneath the moonlit sky.
Comment @coderabbitai help to get the list of available commands.
7dcd909 to
de7ebf6
Compare
Checklist
tools/build_all.py(or CI's board matrix) passesDescription of Change
The color-screen DFU banner still said "meshtastic.org - OTAFIX" on the T096 and T1 and "meshtastic.org - OTAFIX by oltaco" as the TFT default (T114), after the rename. It now reads
meshtastic.org, same as the OLED default; oltaco stays credited in the README. Built for all three, the strings in each ELF confirmed.Summary by CodeRabbit