Repository navigation
fix(usb): identify the UF2 drive as Meshtastic - #95
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update inquiry vendor ID src/usb/msc_uf2.c, changelog.md |
The inquiry vendor ID changes from Adafruit to Meshtast. The changelog records the change and notes that the volume label, INFO_UF2.TXT, and USB descriptors are unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: hathach
Merge Risk: 
fb9b9
-
The UF2 vendor-name update is narrowly scoped and ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main change: the UF2 drive now identifies as Meshtastic through its USB SCSI vendor field. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the UF2 drive,
And sees “Meshtast” shine alive.
The inquiry name has changed its place,
The other labels keep their space.
The changelog notes the name anew,
Then hops along beneath the moon.
Comment @coderabbitai help to get the list of available commands.
The SCSI inquiry vendor reads Meshtast instead of Adafruit.
1291cee to
82b6b9c
Compare
Checklist
tools/build_all.py(or CI's board matrix) passesDescription of Change
The UF2 drive still identified itself as
Adafruit/nRF UF2in its SCSI inquiry, so hosts listed a Meshtastic bootloader as an Adafruit device. It now reports vendorMeshand productMeshtastic UF2; the vendor field holds 8 characters, so the full name goes in the 16-character product field. Nothing reads these fields: android and apple identify the drive fromINFO_UF2.TXT, and no tool or udev rule in the workspace matches on them. Volume label,INFO_UF2.TXTand USB descriptors are unchanged.