Repository navigation
Avoid Internet version checks when displaying local radio information - #996
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 25 25
Lines 4764 4761 -3
=======================================
- Hits 3213 3211 -2
+ Misses 1551 1550 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The local --info command currently contacts PyPI after printing radio information. Off-grid users must wait for the request to fail before the command returns.
Remove that lookup from --info. Radio and node information still print and the connection still closes normally. The existing version check in --support remains available.
Fixes #826.
Validation:
The contributor agreement check is satisfied. The earlier local type-check errors were resolved by installing missing optional dependencies and matching the relevant locked dependency versions; no additional source changes were needed.
Summary by CodeRabbit
Bug Fixes
--infocommand no longer checks for newer versions online or displays upgrade notices.Tests
--infousage across serial and TCP connections.