Repository navigation
Report the connected radio transport and endpoint - #998
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
+ Coverage 67.44% 67.53% +0.09%
==========================================
Files 25 25
Lines 4764 4775 +11
==========================================
+ Hits 3213 3225 +12
+ Misses 1551 1550 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The CLI now reports the transport and endpoint of the interface that actually connected: a serial device path, TCP hostname and port, or BLE address. This also identifies automatically discovered serial devices and TCP fallback connections. Configuration exports continue to omit connection status.
Fixes #950.
Validation: regression tests cover serial, TCP, BLE, a missing BLE client, an unknown interface, and configuration export. Default pytest: 492 passed; fast unit suite: 443 passed; pylint: 10.00/10. Mypy reports the same existing Listener/Callable type error in
meshtastic/slog/slog.py:183on both this branch and unchanged master (84 source files checked).Transport scope:
main()selects BLE, TCP, or serial and falls back to TCP on localhost when serial discovery finds no device. These are the CLI's radio connection paths.--destselects a destination node for sent commands over that existing interface. Commands sent to a remote LoRa node therefore retain the connected serial/TCP/BLE status.Summary by CodeRabbit