Repository navigation
Format remote configuration values consistently with local settings - #999
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 67.44% 68.40% +0.95%
==========================================
Files 25 25
Lines 4764 4769 +5
==========================================
+ Hits 3213 3262 +49
+ Misses 1551 1507 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remote configuration responses now print setting values with the same formatting as local
--getoutput. Singular and repeated byte fields usebase64:values that can be reused with--set, includingsecurity.admin_key, instead of protobuf octal escapes. Received configuration is still copied into the node cache before printing.Fixes #956.
Validation: real protobuf response tests compare remote security and module settings against local output, cover repeated and empty byte values, and verify caching and ACK/NAK handling. Default pytest: 488 passed; pylint: 10.00/10. Mypy reports the same existing Listener/Callable type error in
meshtastic/slog/slog.py:183on this branch and unchanged master (84 source files checked).Summary by CodeRabbit