Skip to content

Fix duplicate PR labels on commits submitted with sl pr - #1482

Open
huntie wants to merge 1 commit into
meta:mainfrom
huntie:pr1482
Open

huntie wants to merge 1 commit into
meta:mainfrom
huntie:pr1482

Conversation

@huntie

@huntie huntie commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix ISL showing duplicate PR labels (state and review status) on commits submitted with sl pr submit. The push to the PR's head branch gives the commit an origin/pr<N> remote bookmark, which ISL renders as a branching PR with its own labels, beside the commit's diff info for the same PR.

  • Skip the branching PR badge when the bookmark's PR is the commit's own; the bookmark label still shows.
Before After

Test Plan

cd addons/isl
yarn jest src/__tests__/GitHubPRBadge.test.tsx

✅ New tests: a commit on its own pr<N> branch renders its PR badge once, and a badge for another PR branch it sits on still renders. The first fails without the fix.

✅ Checked in ISL on a real sl pr stack: one badge per commit (screenshots above).

@meta-cla meta-cla Bot added the CLA Signed label Oct 30, 2026
@huntie huntie changed the title Show each GitHub PR badge once on commits submitted with sl pr Fix duplicate PR labels on commits submitted with sl pr Oct 30, 2026
@meta-codesync

meta-codesync Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D128591657. (Because this pull request was imported automatically, there will not be any future comments.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant