Fix plugin autoclose unused import - #4168
Conversation
JoeKar
left a comment
There was a problem hiding this comment.
You can drop 028ff6f, because for builtin plugins we agreed to stay at v1.0.0.
The version isn't printed anyway:
micro/internal/config/plugin_installer.go
Lines 712 to 716 in 1c8b82b
028ff6f to
5dba61b
Compare
I think this comes from this text:
A comment like this: VERSION = "1.0.0" -- all built-in plugins fixed to 1.0.0in all the plugins would be useful to reflect that policy in the code; in the future, we can change it. I could make a PR with the changes, but I’d like you to give me the reasoning to include in the commit body so the commit history reflects why that decision was made. Maybe the previous quote is enough. Your call. |
No description provided.