fix: preserve mainArtifact default on parse failure in import and import-url

[AdeshDeshmukh]

Both the import and import-url commands accept a :true or :false suffix to mark an artifact as primary or secondary. If that suffix is malformed (e.g. :tru or :xyz), strconv.ParseBool returns false as its zero value — and that false was being unconditionally assigned to mainArtifact, silently overriding the intended default of true.

In practice this means a typo in the boolean flag would cause Microcks to treat the artifact as secondary when the user almost certainly meant it as primary. No clear error, just wrong behavior.

The fix is the same in both files: only assign mainArtifact when ParseBool succeeds. On failure, print a clear warning and keep the default value of true.

Files changed:

• cmd/import.go — replaced the outer var err error + direct assignment with a scoped val variable inside an if/else block. The mainArtifact = val assignment now only runs when parsing succeeds.
• cmd/importURL.go — same pattern: moved mainArtifact = val inside an else block so it only fires on success. Also replaced the raw fmt.Println(err) with a clearer warning message matching the style already used in import.go.

Verification:

go build ./...  — passes
go vet ./...   — no new issues
go test ./...  — all tests pass (1 pre-existing failure in TestDeleteContext, unrelated)

Signed-off-by: Adesh Deshmukh adeshkd123@gmail.com

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves handling of the optional mainArtifact boolean flag in import commands by avoiding unintended value changes when boolean parsing fails.

Changes:

• Prevent mainArtifact from being overwritten when strconv.ParseBool returns an error.
• Replace raw error printing with a clearer parse-failure message.
• Refactor parsing in cmd/import.go to use a scoped parseErr variable and only assign on success.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/importURL.go	Avoids assigning mainArtifact on parse failure and emits a clearer message.
cmd/import.go	Refactors bool parsing to only apply parsed values on success and keep defaults on failure.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.