Repository navigation
Conversation
…ocks#573) Signed-off-by: ish-g09 <ig.valiente09@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
inProgressvariable out of the polling loop incmd/testExecutor.goto track test state after the deadline expires.errors.Wrapf(errors.KindConnection, ...)ifinProgressis still true after the loop so the CLI exits with code 11 instead of 1.renderTestResulton timeouts so unfinished tests are not falsely reported as contract failures (FAILURE 0ms).cmd/testExecutor_test.goassertingerrors.KindConnectionand exit code 11.Related issue(s)
Fixes #573
AI Disclosure
The code changes and unit test were written and verified by me. I fully understand them. I used an AI assistant to discuss the error-handling architecture.
Testing
go build ./...: passesgo test ./...: all packages passgo test -v -count=1 -run TestRunTestAndWait_TimeoutReturnsKindConnection ./cmd: passes (asserts exit code 11)