Repository navigation
Conversation
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the SSO callback server in login.go: each login now uses a private ServeMux, and the CLI binds the port before opening the browser. A bind failure returns a wrapped environment error immediately.
verified with test:
Added both regression tests:
separate callback servers can serve /auth/callback with independent handlers, Occupied port: hold the configured localhost port, call oauth2login, and verify it returns a KindEnvironment error before starting the browser flow.
Private mux: verify callback routes are registered on a per-login mux, so creating two login servers doesn’t panic from duplicate global registrations.
a port conflict returns a KindEnvironment error. go
AI disclosure : Chatgpt is used to analyze related files and changes.
Closes #312