[Krishnadheeraj (DheerajPannala)]

Summary

The integration-test step in .github/workflows/ci.yml ran in the pull_request job with AZURE_OPENAI_API_KEY. That step runs npm run test:integration, which executes the Jest config and test files from the PR itself. So code that hadn't been reviewed yet could read the key (CWE-522).

Change

• Removed the integration-test step from the Node.js SDK job, which runs on every PR.
• Added an Integration tests job that:
  • runs only on push (after merge)
  • is bound to the integration-tests environment
  • keeps the same Node 18/20 matrix and runs after the SDK job

Lint, unit tests, build and pack still run on every PR.

Why an environment

A pull_request run uses the workflow file from the PR, so an if: condition alone can be edited away by the PR author. An environment secret is only released to jobs whose ref passes the environment's deployment rules. With the environment limited to main, PR-authored workflows can't read the key, even if edited.

Admin step after merge

Until this step is done, the job falls back to the existing repository secret, so CI keeps working.

1. Settings → Environments → create or open integration-tests → Deployment branches and tags → Selected branches → add main.
2. Rotate the Azure OpenAI key, and add the new key as the environment secret AZURE_OPENAI_API_KEY.
3. Delete the repository-level AZURE_OPENAI_API_KEY secret.

[Copilot]

🟡 Changes recommended

Same-repository PRs can bypass the workflow condition, so secret access needs an independently enforced protection boundary.

1 open finding

• Enforce secret access outside PR-editable workflow code · New

What changed in this PR

Restricts secret-bearing integration tests to push runs while preserving other PR validation.

Changes:

• Adds a push-only condition to the integration-test step.
• Documents why unreviewed PR code should not receive repository secrets.

File	Description
.github/​workflows/​ci.yml	Gates integration tests on push events.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dbezic (dbezic)]

Do we want to disable integration tests for PRs? I feel like there should be another fix for this

[Copilot]

🔵 Needs a closer look

Maintainers must verify environment branch restrictions and confirm the API key is unavailable through repository or organization secrets.

No open issues 🎉

1 resolved since last review

• Enforce secret access outside PR-editable workflow code

_{Review effort: Balanced}