Skip to content

Eliminate warning #9780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexander-Ya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eliminate warning #9780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Layers/W1/BaseApp/Integration/FieldService/FSProjectTask.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,31 +86,47 @@ table 6404 "FS Project Task"
TableRelation = "CRM SystemUser".SystemUserId;
DataClassification = SystemMetadata;
}
#if not CLEAN29
field(8; CreatedByName; Text[100])
#else
field(8; CreatedByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM SystemUser".FullName where(SystemUserId = field(CreatedBy)));
ExternalName = 'createdbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(10; CreatedOnBehalfByName; Text[100])
#else
field(10; CreatedOnBehalfByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM SystemUser".FullName where(SystemUserId = field(CreatedOnBehalfBy)));
ExternalName = 'createdonbehalfbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(12; ModifiedByName; Text[100])
#else
field(12; ModifiedByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(ModifiedBy)));
ExternalName = 'modifiedbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(14; ModifiedOnBehalfByName; Text[100])
#else
field(14; ModifiedOnBehalfByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(ModifiedOnBehalfBy)));
Expand Down Expand Up @@ -260,5 +276,5 @@ table 6404 "FS Project Task"
{
}
}
}
}
#endif
16 changes: 16 additions & 0 deletions src/Layers/W1/BaseApp/Integration/FieldService/FSResourcePayType.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,31 +85,47 @@ table 6206 "FS Resource Pay Type"
TableRelation = "CRM Systemuser".SystemUserId;
DataClassification = SystemMetadata;
}
#if not CLEAN29
field(8; CreatedByName; Text[100])
#else
field(8; CreatedByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(CreatedBy)));
ExternalName = 'createdbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(10; CreatedOnBehalfByName; Text[100])
#else
field(10; CreatedOnBehalfByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(CreatedOnBehalfBy)));
ExternalName = 'createdonbehalfbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(12; ModifiedByName; Text[100])
#else
field(12; ModifiedByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(ModifiedBy)));
ExternalName = 'modifiedbyname';
ExternalType = 'String';
ExternalAccess = Read;
}
#if not CLEAN29
field(14; ModifiedOnBehalfByName; Text[100])
#else
field(14; ModifiedOnBehalfByName; Text[200])
#endif
{
FieldClass = FlowField;
CalcFormula = lookup("CRM Systemuser".FullName where(SystemUserId = field(ModifiedOnBehalfBy)));
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/Manufacturing/Warehouse/Activity/MfgWhsePickRqstDocType.EnumExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// ------------------------------------------------------------------------------------------------
namespace Microsoft.Warehouse.Activity;

enumextension 99000776 "Mfg. Whse. Pick Rqst. Doc. Type" extends "Warehouse Pick Request Document Type"
enumextension 99000776 "Mfg. WhsePickRqstDocType" extends "Warehouse Pick Request Document Type"
{
value(2; "Production") { Caption = 'Production'; }
}
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/Manufacturing/Warehouse/Activity/MfgWhsePutAwayRqstDocType.EnumExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// ------------------------------------------------------------------------------------------------
namespace Microsoft.Warehouse.Activity;

enumextension 99000780 "Mfg. Whse. PutAway Rqst. Doc. Type" extends "Warehouse Put-away Request Document Type"
enumextension 99000780 "Mfg. WhsePutAwayRqstDocType" extends "Warehouse Put-away Request Document Type"
{
value(2; "Production") { Caption = 'Production'; }
}
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/OtherCapabilities/RetentionPolicy/RetenPolDocArchiveFltrng.EnumExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace System.DataAdministration;

enumextension 3999 "Reten. Pol. Doc. Archive Fltrng." extends "Reten. Pol. Filtering"
enumextension 3999 "Reten. Pol.Doc.Archive Fltrng." extends "Reten. Pol. Filtering"
{
value(3999; "Document Archive Filtering")
{
Expand Down
8 changes: 5 additions & 3 deletions src/Layers/W1/BaseApp/System/Workflow/WorkflowWebhookNotification.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ codeunit 1545 "Workflow Webhook Notification"
NotificationUrlTxt: Label 'NotificationUrl';
WorkflowWebhookCategoryLbl: Label 'AL Workflow Webhook', Locked = true;
WorkflowWebhookCorrelationGuidTxt: Label 'Correlation GUID for workflow webhook notification created: %1', Locked = true;
WorkFlowErrorDetailsTxt: Label '%1 - StatusCode: %2 - StatusDescription: %3', Comment = '%1=ErrorDetails, %2=StatusCode, %3=StatusDescription', Locked = true;

procedure Initialize(RetryCount: Integer; WaitTimeInMs: Integer)
begin
Expand Down Expand Up @@ -95,8 +96,9 @@ codeunit 1545 "Workflow Webhook Notification"
HttpWebResponse := WebException.Response;
if not IsNull(HttpWebResponse) then
if not IsNull(HttpWebResponse.StatusCode) then begin
ErrorDetails := StrSubstNo('%1 - StatusCode: %2 - StatusDescription: %3', ErrorDetails,
Format(HttpWebResponse.StatusCode), HttpWebResponse.StatusDescription);
ErrorDetails :=
StrSubstNo(
WorkFlowErrorDetailsTxt, ErrorDetails, Format(HttpWebResponse.StatusCode), HttpWebResponse.StatusDescription);
Retry := ShouldRetry(HttpWebResponse.StatusCode, HttpWebResponse.StatusDescription);
end;
end;
Expand All @@ -116,7 +118,7 @@ codeunit 1545 "Workflow Webhook Notification"
end;

[TryFunction]
[IntegrationEvent(true, true)]
[IntegrationEvent(true, false)]
[Scope('OnPrem')]
procedure OnPostNotificationRequest(DataID: Guid; WorkflowStepInstanceID: Guid; NotificationUrl: Text; RequestedByUserEmail: Text)
begin
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocument.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ page 189 "Incoming Document"
ReplaceMainAttachmentEnabled := Rec.CanReplaceMainAttachment();
end;

[IntegrationEvent(true, true)]
[IntegrationEvent(true, false)]
local procedure OnCloseIncomingDocumentFromAction(var IncomingDocument: Record "Incoming Document")
begin
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ page 190 "Incoming Documents"
AutomaticCreationActionsAreEnabled := Rec."Data Exchange Type" <> '';
end;

[IntegrationEvent(true, true)]
[IntegrationEvent(true, false)]
local procedure OnCloseIncomingDocumentsFromActions(var IncomingDocument: Record "Incoming Document")
begin
end;
Expand Down
Loading