Skip to content

[releases/28.x] [Shopify] Fix duplicate object id in code coverage merge - #9798

Merged
onbuyuka merged 1 commit into
releases/28.xfrom
bugs/644543-shpfy-transactions-test-id
Jul 29, 2026
Merged

[releases/28.x] [Shopify] Fix duplicate object id in code coverage merge#9798
onbuyuka merged 1 commit into
releases/28.xfrom
bugs/644543-shpfy-transactions-test-id

Conversation

@onbuyuka

@onbuyuka onbuyuka commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the autodetected build break tracked by Bug 644543 (RunALTestBusinessFoundationModules_Group1 gate task failing on releases/28.x).

Root cause

Shpfy Transactions Test was backported to releases/28.x as codeunit 139554. The code-coverage merger (CCMerger) flattens all W1 sources — BCApps and the NAV-native tree — into a single object namespace keyed by country:id:type. The NAV-native Library - Intrastat codeunit is also 139554, so the merge failed with:

Duplicated object id in file: '...\Shopify\Test\Transactions\ShpfyTransactionsTest.Codeunit.al'
with app\apps\w1\intrastat\test\src\libraryintrastat.codeunit.al
System.ArgumentException: An item with the same key has already been added.

Fix

Renumber the test codeunit 139554 → 139575. Verified empirically:

  • 139575 is unused repo-wide across BCApps releases/28.x.
  • NAV-native Intrastat on 28.x only occupies 139550 and 139554 in the 139xxx space.
  • The failing merge itself proves every other Shopify Test id merges cleanly, so a free slot is safe.

Fixes AB#644543

…rge (Bug 644543)

"Shpfy Transactions Test" was backported to releases/28.x as codeunit 139554,
which collides with the NAV-native "Library - Intrastat" (also codeunit 139554)
when the code coverage merger (CCMerger) flattens all W1 sources into a single
object namespace. This broke the RunALTestBusinessFoundationModules_Group1 gate
task ("Duplicated object id ... An item with the same key has already been added").

Renumber the test codeunit to 139575, a free id in the Shopify Connector Test
app's declared range that is unused across the merged W1 object space.

Fixes AB#644543

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 32221ea5-af73-4f67-8e02-ff20f0e6dbe5
@onbuyuka
onbuyuka requested a review from a team July 28, 2026 14:17
@onbuyuka
onbuyuka requested a review from a team as a code owner July 28, 2026 14:17
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 28, 2026
@onbuyuka
onbuyuka enabled auto-merge (squash) July 28, 2026 14:17
@github-actions github-actions Bot added this to the Version 28.4 milestone Jul 28, 2026
@onbuyuka onbuyuka changed the title [releases/28.x] [Shopify] Fix duplicate object id in code coverage merge (Bug 644543) [releases/28.x] [Shopify] Fix duplicate object id in code coverage merge Jul 28, 2026
@github-actions github-actions Bot added the Integration GitHub request for Integration area label Jul 29, 2026
@onbuyuka
onbuyuka merged commit 66db8f8 into releases/28.x Jul 29, 2026
122 of 134 checks passed
@onbuyuka
onbuyuka deleted the bugs/644543-shpfy-transactions-test-id branch July 29, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Integration GitHub request for Integration area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants