Generate safe COM output pointer ABI - #1829
Closed
Jevan Saks (jevansaks) wants to merge 1 commit into
Closed
Jevan Saks (jevansaks) wants to merge 1 commit into
Jevan Saks (jevansaks) wants to merge 1 commit into
Conversation
Project canonical IID/ComOutPtr pairs as out void* and provide ComOutPtr.FromManaged for managed COM implementers. Preserve friendly generic overloads and cover source-generated, built-in, and WinRT marshalling configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Superseded by #1831, which uses the branch hosted directly in microsoft/CsWin32. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IID + [ComOutPtr] void**interface parameters as implementation-safeout void*Windows.Win32.ComOutPtr.FromManagedto return the exact requested interface with caller-owned COM reference semanticsout Tfriendly overloads and adaptive COM/WinRT projectionUseIntPtrForComOutPointersbehaviorIClassFactoryimplementations across source-generated COM, built-in COM, and auto-WinRT enabled/disabled configurationsFixes #1827
Validation
IClassFactoryruntime tests passed on .NET 9 and .NET 10git diff --checkpassed