Describe what each passed FlightCheck validated#149
Open
GrahamMcMynn wants to merge 2 commits into
Open
Conversation
Passing checks previously left `remediation` empty, so a green row gave no insight into what the check actually confirmed. Populate the `remediation` of every PASSED result with a "Validated: ..." note stating the exact success criterion (which API / field / value made it pass), so an operator reading a passing row can see what was verified. - Add "Validated: ..." remediation to all ~54 passed-producing CheckResult branches across the check modules (authentication, connections, environment, external_systems, graph_connector_kb, licensing, local_files, prerequisites, servicenow, workday), including the conditional pass/fail constructors. - Update flightcheck/AGENTS.md principle 8: PASSED results now carry a "Validated: ..." note instead of an empty remediation. - Update the tests that pinned the old "passed has no remediation" convention to assert the new "Validated: ..." text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…assed-remediation # Conflicts: # solutions/ess-maker-skills/scripts/flightcheck/checks/connections.py # solutions/ess-maker-skills/scripts/flightcheck/checks/servicenow.py
Contributor
|
👋 Friendly reminder: This PR has been inactive for a while. Could the author or reviewers take a look and either push it forward, request changes, or close it if it's no longer needed? Let's keep our PR queue healthy! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a FlightCheck result passes, the report previously showed nothing under Remediation, so a green row gave no insight into what the check actually confirmed. This PR populates the
remediationof every PASSED result with a concise "Validated: …" note stating the exact success criterion (which API / field / value made the check pass) — enough to understand what was verified.What changed
Validated: …remediation to all ~54 passed-producingCheckResultbranches across the check modules:authentication,connections,environment,external_systems,graph_connector_kb,licensing,local_files,prerequisites,servicenow,workday— including the conditional pass/fail constructors (the pass branch now carries the Validated note, the fail branch keeps its fix text).flightcheck/AGENTS.mdprinciple 8: PASSED results now carry aValidated: …note rather than an empty remediation.Validated: …text.Example
Tenant: Contoso (…)Validated: the tenant exposes a Microsoft Entra ID organization record via Microsoft Graph (GET /organization returned an org with a displayName and id).All 2 Workday connection(s) report healthy auth stateValidated: all 2 Workday connection(s) report a healthy auth state (Connected with no token/credential error) via the Power Platform connections API.Verification
ruff check solutions/ess-maker-skills/scripts— cleanpytest tests— 592 passed, 8 skipped (8 pre-existing skips)Notes
Independent of #148 (the Role column PR); no expected conflicts.