Skip to content

tests: adds validation tests for circular reference handling #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 1 commit into from
Aug 13, 2026
+72 −0
Merged

tests: adds validation tests for circular reference handling #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiSchemaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,78 @@ public void ParseBasicSchemaWithReferenceShouldSucceed()
}, options => options.Excluding(m => m.Name == "HostDocument"));
}

[Fact]
public void ParseSchemaWithCircularPropertyReferencesShouldSucceed()
{
var openApiDoc = new OpenApiStringReader().Read("""
{
"openapi": "3.0.0",
"info": {
"title": "Test",
"version": "0.0.1"
},
"paths": {},
"components": {
"schemas": {
"A": {
"properties": {
"b": {
"$ref": "#/components/schemas/B"
}
}
},
"B": {
"properties": {
"a": {
"$ref": "#/components/schemas/A"
}
}
}
}
}
}
""", out var diagnostic);

diagnostic.Should().BeEquivalentTo(
new OpenApiDiagnostic { SpecificationVersion = OpenApiSpecVersion.OpenApi3_0 });

var schemaA = openApiDoc.Components.Schemas["A"];
var schemaB = openApiDoc.Components.Schemas["B"];

schemaA.Properties["b"].Should().BeSameAs(schemaB);
schemaB.Properties["a"].Should().BeSameAs(schemaA);
}

[Fact]
public void ParseSchemaWithCircularRootReferencesShouldSucceed()
{
var openApiDoc = new OpenApiStringReader().Read("""
{
"openapi": "3.0.0",
"info": {
"title": "Test",
"version": "0.0.1"
},
"paths": {},
"components": {
"schemas": {
"A": {
"$ref": "#/components/schemas/B"
},
"B": {
"$ref": "#/components/schemas/A"
}
}
}
}
""", out var diagnostic);

diagnostic.Should().BeEquivalentTo(
new OpenApiDiagnostic { SpecificationVersion = OpenApiSpecVersion.OpenApi3_0 });

openApiDoc.Components.Schemas["A"].Should().BeSameAs(openApiDoc.Components.Schemas["B"]);
}

[Fact]
public void ParseAdvancedSchemaWithReferenceShouldSucceed()
{
Expand Down
Loading