MAINT: pyrit.common - relocate two packages that don't belong#2001
Open
rlundeen2 wants to merge 2 commits into
Open
MAINT: pyrit.common - relocate two packages that don't belong#2001rlundeen2 wants to merge 2 commits into
rlundeen2 wants to merge 2 commits into
Conversation
Relocate the data-URL and question-answering helpers out of pyrit.common so the import-boundary reverse guard can be enforced without exceptions: - pyrit.common.data_url_converter -> pyrit.memory.storage.data_url_converter - pyrit.common.question_answer_helpers -> pyrit.score.question_answer_helpers Each old path keeps a one-release deprecation re-export shim (module_deprecation_getattr, removed_in 0.16.0) with a note to update KNOWN_COMMON_VIOLATIONS in test_import_boundary.py on removal. Internal callers and test patch targets are repointed, and the two relocated entries are dropped from KNOWN_COMMON_VIOLATIONS. display_response is left in place (slated for deletion) and keeps its violation entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Per the style guide, import convert_local_image_to_data_url_async from the pyrit.memory.storage package root (where it is re-exported) rather than the full submodule path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocate the data-URL and question-answering helpers out of pyrit.common so the import-boundary reverse guard can be enforced without exceptions:
Each old path keeps a one-release deprecation re-export shim (module_deprecation_getattr, removed_in 0.16.0) with a note to update KNOWN_COMMON_VIOLATIONS in test_import_boundary.py on removal. Internal callers and test patch targets are repointed, and the two relocated entries are dropped from KNOWN_COMMON_VIOLATIONS. display_response is left in place (slated for deletion) and keeps its violation entry.
Phase 18: https://gist.github.com/rlundeen2/3e8daa8e12a11b4b6e52587b3c9b1dca