Repository navigation
FIX: Read manual XPIA input off the event loop - #3775
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3719.
XPIAManualProcessingWorkflowsets a processing callback that calledinput()directly inside an async function, so the event loop stopped for as long as the operator took to trigger the processing target and paste its output. Any other async work, such as other attacks, scorers or target calls, waited with it.The callback now reads the console with
await asyncio.to_thread(input, prompt). The prompt text and the returned value are unchanged.Tests and Documentation
Added
TestXPIAManualProcessingWorkflowtotests/unit/executor/workflow/test_xpia.py:input()only returns after a task on the event loop releases it, so the test fails if the read blocks the loop and passes once it runs in a worker thread.No docs or notebooks changed, so JupyText was not needed.