Repository navigation
FIX: Move streaming PCM file work off the event loop in PromptNormalizer - #3778
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3720.
PromptNormalizer.convert_audio_asyncwrote the incoming PCM to a temp WAV, read the converted WAV back and deleted the temp file with synchronoustempfile,waveandpathlibcalls on the event loop. In a realtime streaming session this runs for every audio turn that has request converters, so other async work stalled while it ran.The write, the read and the cleanup now run through
asyncio.to_thread. The cleanup stays in thefinallyblock, and the worker thread completes the removal even if the task is cancelled during that await.One case needed extra handling. A worker thread cannot be stopped, so if the caller is cancelled while the temp WAV is still being written, the thread goes on to create the file but the caller never gets its path.
_write_pcm_to_temp_wav_asyncshields the write and, when the caller is cancelled, removes the file once the write finishes, so no temp file is left behind. The converted PCM, the format mismatch check and the no-converter fast path are unchanged.Tests and Documentation
Added tests in
tests/unit/prompt_normalizer/test_prompt_normalizer.py:No docs or notebooks changed, so JupyText was not needed.