[codex] Preserve fractional rollout hard scores#104
Merged
Yif-Yang merged 1 commit intoJul 14, 2026
Merged
Conversation
Rollout hard scores can be continuous when smoothed rewards are used. Converting the field through int() turned values like 0.75 into 0, which loses signal before scoring and serialization. Constraint: Keep the existing RolloutResult dictionary shape unchanged. Rejected: Clamp hard scores to 0 or 1 | contradicts existing continuous-score support in compute_score and sleep replay types. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Treat hard as numeric reward data, not only a binary label. Tested: uv run --with pytest pytest tests/test_types.py tests/test_scoring.py -q Tested: uv run --with ruff ruff check skillopt/types.py tests/test_types.py Not-tested: Full benchmark rollouts.
Contributor
|
Hi @zixuanguo786-ctrl — preserving fractional hard scores looks correct and I verified the truncation fix locally (0.75 no longer becomes 0), tests pass. Still in draft — ready to merge? |
Contributor
Author
|
@microsoft-github-policy-service agree |
zixuanguo786-ctrl
marked this pull request as ready for review
July 14, 2026 01:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RolloutResult.hardas a float instead of truncating throughint().0.75throughfrom_dict()andto_dict().Test plan
uv run --with pytest pytest tests/test_types.py tests/test_scoring.py -quv run --with ruff ruff check skillopt/types.py tests/test_types.py