Skip to content

fix(sleep): harden OpenAI compatibility boundaries#138

Merged
Yif-Yang merged 1 commit into
microsoft:mainfrom
Yif-Yang:fix/sleep-openai-compat-safety
Jul 14, 2026
Merged

fix(sleep): harden OpenAI compatibility boundaries#138
Yif-Yang merged 1 commit into
microsoft:mainfrom
Yif-Yang:fix/sleep-openai-compat-safety

Conversation

@Yif-Yang

Copy link
Copy Markdown
Contributor

Summary

  • require HTTPS as well as an allowed Azure hostname before constructing the managed-identity client
  • send SKILLOPT_SLEEP_CHAT_EXTRA_BODY only in explicit OpenAI-compatible mode
  • add regression tests for plaintext Azure endpoints and native-Azure request isolation

This is a narrow maintainer follow-up to #129. We merged the contributor's feature first so its authorship and contribution history remain intact, then added these two defense-in-depth fixes separately.

Tests

  • pytest tests/test_azure_openai_compat.py -q — 19 passed
  • pytest tests/ -q — 296 passed, 6 skipped
  • git diff --check

@Yif-Yang
Yif-Yang merged commit efb30b4 into microsoft:main Jul 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant