Repository navigation
Tokenize type on the line after as or satisfies - #1080
Open
Tomer Aberbach (TomerAberbach) wants to merge 1 commit into
Open
Tomer Aberbach (TomerAberbach) wants to merge 1 commit into
Tomer Aberbach (TomerAberbach) wants to merge 1 commit into
Conversation
When a line ends with `as` or `satisfies`, the type on the next line receives expression scopes. In `b as\n A | undefined`, `A` is a variable, `|` a bitwise operator, and `undefined` a constant. The `as`/`satisfies` rule ends the type at `$` and `^`, so the type ends at the line break right after the keyword. Prettier emits this layout when an `as` expression exceeds the print width. A separate rule now matches `as` or `satisfies` at the end of a line, modeled on the rule for a return type that starts on the next line. It ends the type at the end of the first non-empty line that lacks a trailing `|` or `&`, instead of at the line break after the keyword. A union written with a leading `|` on each line still ends after its first member, because the end pattern cannot match past the current line to check whether the next line continues the type. Multi-line return types have the same limitation. Fixes microsoft#1079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a line ends with
asorsatisfies, the type on the next line receives expression scopes. Inb as\n A | undefined,Ais a variable,|a bitwise operator, andundefineda constant. Theas/satisfiesrule ends the type at$and^, so the type ends at the line break right after the keyword. Prettier emits this layout when anasexpression exceeds the print width.A separate rule now matches
asorsatisfiesat the end of a line, modeled on the rule for a return type that starts on the next line. It ends the type at the end of the first non-empty line that lacks a trailing|or&, instead of at the line break after the keyword.A union written with a leading
|on each line still ends after its first member, because the end pattern cannot match past the current line to check whether the next line continues the type. Multi-line return types have the same limitation.Fixes #1079