Fix build break: return DownloadAttemptResult from the malformed-SHA guard - #2091
Merged
tyrielv merged 1 commit intoAug 14, 2026
Merged
Conversation
The malformed-SHA guard in TryDownloadAndSaveObject returned the bare DownloadAndSaveObjectResult enum. The method now returns DownloadAttemptResult (the enum plus an HTTP status code), so the build failed with CS0029. Wrap the error in a DownloadAttemptResult with a null status code, matching the AllZeroSha guard just below it. Assisted-by: Claude Opus 4.8 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
enabled auto-merge
August 14, 2026 22:10
Keith Klein (KeithIsSleeping)
approved these changes
Aug 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a build break on
mastercaused by a merge-order semantic conflictbetween two changes that were each green on their own branch:
DownloadAndSaveObjectResult.Error.TryDownloadAndSaveObjectto returnDownloadAttemptResult(the result enum plus an HTTP status code).
Merged together, the guard returned the bare enum where a
DownloadAttemptResultwas expected, so the build failed with:
Fix: wrap the error in a
DownloadAttemptResultwith a null status code,matching the
AllZeroShaguard immediately below it.Verification:
GVFS.Commonbuilds clean; full unit suite passes (917 passed,0 failed, 11 skipped).