allow specifying an adapter name also when using DXGI

[Harald Deischinger (deischi)]

I see no need to use DXCORE to specify an adapter name.

[Microsoft Contribution License Agreements (msftclas)]

All CLA requirements met.

[Ryan Lai (ryanlai2)]

Hi Harald Deischinger (@deischi), thank you for your contribution! It's correct that specifying adapter name shouldn't be constrained to DxCore.

I have a few suggested changes:

• There is already a conditional to handle if "-GPUAdapterName" flag is used. Can your code to choose adapter be added inside here?:
  

  Windows-Machine-Learning/Tools/WinMLRunner/src/Run.cpp

  Line 210 in ed0b176

  else if ((TypeHelper::GetWinmlDeviceKind(deviceType) != LearningModelDeviceKind::Cpu) && !adapterName.empty())

• Within the conditional of (WinMLDeviceKind isn't CPU and adaptername isn't empty). One flow can be like this:

  • Try to use DXGI to enumerate adapters
  • Fall back to using DxCore if DXGI doesn't work / isn't available.
  • #ifdef check for DXCORE_SUPPORTED_BUILD will need to be around the DxCore code.
  • Create Session with chosen adapter.

• Check for first matching substring for adapter name.

• Spaces instead of tabs for spacing.

Thanks! Let me know if you have any questions.

[Harald Deischinger (deischi)]

I have tried to add my changes as local and small as possible to quickly get a result.

You are right, having the adapter selection only once would be better.
Please understand that improving the WinMlRunner is not one of the top priorities, so it will definitely take some time until come to that.
Also I have no access to DXCore, any changes I will do related to that will be done blindly.