Revert "Adopt PublishWithContainerFiles for frontend assets and remove esproj coupling"#1332
Merged
IEvangelist merged 1 commit intoJul 6, 2026
Conversation
…ove `esp…" This reverts commit eb81267.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts aspire.dev#1171 by restoring the prior approach of coupling the StaticHost build to the frontend frontend.esproj (instead of publishing frontend assets via PublishWithContainerFiles from the AppHost).
Changes:
- Reintroduces a
ProjectReferencefromStaticHosttofrontend.esproj(intended to bring frontend build outputs back into the StaticHost pipeline). - Removes
AddViteApp(...)andPublishWithContainerFiles(...)from the deployment/publish path; keeps Vite only for local run mode. - Adds
frontend.esprojback into the solution file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/statichost/StaticHost/StaticHost.csproj | Restores a build-time dependency on frontend.esproj (with an attempt to prevent transitive propagation). |
| src/apphost/Aspire.Dev.AppHost/AppHost.cs | Removes container-files publishing of frontend assets; Vite is now only created in run mode. |
| Aspire.Dev.slnx | Adds src/frontend/frontend.esproj back to the solution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danegsta
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1171