fix(agentchat): preserve TextMentionTermination sources on serialization - #8288
Open
澍 (icearia0219) wants to merge 1 commit into
Open
澍 (icearia0219) wants to merge 1 commit into
澍 (icearia0219) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression tests covering source-filtered and composite serialization round-trips.
Review effort: Lite
Findings: 1
What changed in this PR
Preserves TextMentionTermination.sources during serialization, including nested composite conditions.
Changes:
- Adds optional, backward-compatible
sourcesconfiguration. - Restores source filters when loading components.
- Automated tests were not run.
| File | Summary |
|---|---|
python/packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py |
Updates termination configuration serialization and restoration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+152
to
+155
| return TextMentionTerminationConfig( | ||
| text=self._termination_text, | ||
| sources=list(self._sources) if self._sources is not None else None, | ||
| ) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextMentionTermination.sourceswhen dumping a component.Noneso previously serialized configs remain loadable.Fixes #8282
Validation
git diff --checkpassed.