Repository navigation
Conversation
Match installed dependency discovery to the build so Apple consumers do not silently switch SQLite or zlib providers. Preserve non-vcpkg Apple behavior and shared-package dependency isolation. Files: cmake/MSTelemetryConfig.cmake.in, tests/vcpkg/package-dependency-tests.cmake, .github/workflows/test-vcpkg.yml, docs/maintainer-onboarding.md, docs/building-with-vcpkg.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812576a3-8932-4848-bc8b-d17af18f65f2
7 tasks done
…k conflicts Record dependency provenance before SDK discovery creates transitive targets, so static consumers reconstruct the same providers and shared consumers do not acquire private package requirements. Require caller-provided targets explicitly. Namespace bundled SQLite functions and data from the header and both amalgamations, including Windows APIs and debug globals. Keep the forced include private so minimal and full SDK SQLite coexist with application SQLite. Separate the registry promotion recipe from development-only overlay behavior: pin archives, keep required external dependencies in core, and allow TLS unions. Exercise provider metadata, missing-target errors, release promotion, and source/installed coexistence without weakening existing tests. Files changed: - .github\scripts\prepare-vcpkg-release.py - .github\workflows\test-embedding.yml - .github\workflows\test-vcpkg.yml - CMakeLists.txt - cmake\MSTelemetryConfig.cmake.in - cmake\MatsdkDependencyTargets.cmake - cmake\MatsdkSqliteNamespace.cmake - docs\building-with-vcpkg.md - docs\maintainer-onboarding.md - lib\CMakeLists.txt - tests\embedding\CMakeLists.txt - tests\package-coexistence\CMakeLists.txt - tests\package-coexistence\main.cpp - tests\package-dependencies\CMakeLists.txt - tests\vcpkg\CMakeLists.txt - tests\vcpkg\native-feature-tests.cmake - tests\vcpkg\package-dependency-tests.cmake - tests\vcpkg\test-release-port.py - tools\registry-ports\cpp-client-telemetry\portfile.cmake - tools\registry-ports\cpp-client-telemetry\vcpkg.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812576a3-8932-4848-bc8b-d17af18f65f2
bmehta001
changed the title
Regenerate the public version for SDK 3.10.280.1 and SPM 3.10.280 without changing published tags or the generator policy. Files changed: lib\include\public\Version.hpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812576a3-8932-4848-bc8b-d17af18f65f2
bmehta001
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare SDK release
3.10.280.1and its corresponding SPM version3.10.280.Regenerate the public version header through the existing Windows generator and
verify the same version with the Linux generator.
Expand the original Apple export fix into release-ready dependency packaging and bundled SQLite isolation. Published SDK/SPM tags remain unchanged; microsoft/vcpkg#54342 keeps its compatibility patch against the immutable older release.
MINIMALandVENDOREDSQLite with SDK-private function/data names, including Windows-only APIs and debug globals absent fromsqlite3.h. Apply the forced renaming header only to SDK-owned code and tests; do not export it to consumers.Validation
No test exclusions were added. Offline-storage runs select the relevant suites, not the entire unit suite. The existing one-second throughput test is Release-only (
NDEBUG) and passed there; Debug retains its original non-timing coverage. The generated-config fixtures exercise the actual helpers with controlled package targets; they are not native Apple builds.Native Apple/Android validation and the remaining upstream workflows must pass for this expanded head before merging. The committed registry recipe is a promotion template: the release helper must replace its version/tag/hash with the forthcoming release containing these fixes, followed by exact published-archive graph validation. Do not reuse or move the already published tags.