Add an editor context menu for selected text - #929
Open
Arham Amin (arhxam) wants to merge 3 commits into
Open
Conversation
|
Arham Amin (@arhxam) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #854.
Summary
Right-clicking inside the current text selection now opens a small in-editor context menu with Cut, Copy, Paste, Select All, and Find. The menu reuses Edit's existing command, localization, clipboard, and TUI menu primitives, so the actions behave the same as their Edit-menu and keyboard-shortcut equivalents.
The popup follows the click position, flips toward the viewport when opened near the right or bottom edge, supports normal keyboard focus, and closes on Escape, command activation, or focus loss. Right-clicks outside a selection keep the existing behavior.
Test plan
cargo test -p edit --bin edit draw_editor::tests::right_clicking_selected_text_opens_context_menu -- --nocapturecargo test --workspacecargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningsThe regression test creates a real selection, delivers a right-mouse event through the TUI input path, and verifies the rendered popup contains each requested localized command.