Repository navigation
Agentic Card: extend contract tests and native structure checks - #4411
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
srividyaramas
requested review from
Jason Morse (JasonVMo),
Khalef Hosany (Khalef1) and
Anandraj (mganandraj)
October 28, 2026 22:10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Record exact resize request, response and read-back bounds. On failure, include bounded window, preview and section measurements while retaining the original error as cause and restoring the original window in finally. This is diagnostic evidence, not a macOS geometry fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Request the primary-screen top-left so the host can use its available screen height instead of retaining the old offset during native size clamping. Keep actual bounds diagnostics, positive section geometry, reading order, existing waits and exact original-window restoration unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Jason Morse (JasonVMo)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adds unit coverage and native Storybook checks for Card's structured reading order and an independently enabled nested action inside a disabled selectable surface. The product implementation is unchanged.
Testing
Keyboard, pointer, and wheel input were disabled for that native run. Existing input-dependent skips are not counted as passes. Subsequent native CI results are recorded below.
The Storybook TypeScript configuration also includes Card's story file so its native test callbacks are type-checked.
These initial results were local; exact-head CI results are recorded below. No all-platform or overall readiness claim is made. The Windows tooling repair landed separately in #4400 and is not included in this PR.
Native test follow-up
Both macOS renderer reports reached the authored checks, but the geometry check failed because the 302-high native host left zero preview height above Storybook's 300-high addons panel. The earlier nonshrinking story wrapper alone did not resolve that host constraint.
At commit
9616c361537ed6b734a6a5e49ca71e813b35584b, the geometry callback requests sufficient native window space, waits for positive header geometry, and restores the original window rectangle infinally. All positive section-height and reading-order assertions remain, with an additional positive-height assertion for the nested action. There are no runtime changes, platform skips, timeout changes, or physical-input requirements.Package build, lint, formatting, Storybook type-checking, contract checks, 568 owning-package unit cases, and 8 snapshots passed. Both authored Card callbacks passed once, without skips or retries, in the exact-head Win32 run. macOS and Windows bundles passed. CI subsequently confirmed both callbacks passed on Windows Fabric and Win32, but both Mac renderers still timed out waiting for positive header geometry. The nested-action check passed on both Mac renderers.
That correction's cache-cleared root aggregate passed all 175 tasks on an unpublished combined validation branch, with the Card, Checkbox, and Dropdown source subtrees verified identical to their isolated PR heads. The tooling and combined validation commits are not included in this PR.
Geometry diagnostics
Commit
6fd046ff8f9ddc4c0dba6c0f7868538d0c6de530adds failure-only diagnostics, not another claimed Mac fix. The callback records requested, returned, and read-back window bounds and, on failure, reports current native window, preview, and section rectangles before restoring the original window. The original error remains the cause; diagnostic read errors are explicit. Existing assertions, timeout, and cleanup remain unchanged.Package checks, 568 unit cases and 8 snapshots, both bundles, diagnostic-path probes, and both exact-head Win32 callbacks passed. The final cache-cleared combined root aggregate did not pass: 104 tasks passed and the unchanged Storybook sourceConfig subprocess hit its existing 10-second limit. A focused reproduction failed the same way on the restored original tooling baseline. No timeout, concurrency, or tooling setting was changed.
That diagnostic head subsequently produced the native Mac evidence described below. No extra unit cases or native callbacks are added by these follow-ups, and no all-platform or readiness claim is made.
Window positioning correction
Both diagnostic Mac reports recorded the same requested window at
(89,322)with size1024x768, but returned and read-back bounds were only935x385; the preview had height 4. The native driver applies position before size and returns a fresh AX frame. These observations support a native screen/work-area constraint; the exact private constraint algorithm is not established.Commit
007b890d53b064a322ad2ca41317129fa4d71a4echanges only the temporary requested origin to(0,0)so resizing is not constrained by the old offset. The system may adjust that request; the callback does not require an exact window size. All geometry assertions, diagnostics, waits, and restoration of the original position and size remain unchanged. No runtime, driver, native helper, or framework code changes.Package checks, 568 unit cases and 8 snapshots, both bundles, regression probes, and both exact-head Win32 callbacks passed. The cache-cleared root aggregate again recorded 104 passed tasks and one unchanged sourceConfig subprocess timeout. This time the isolated baseline's two sourceConfig tests passed; prior exact-baseline failures remain recorded. This is not a fully green local root aggregate. No timeout or concurrency setting was changed.
At this exact head, CI run
40801316209passed all reported checks, includinglicense/cla. The actual macOS Fabric and Paper reports each confirm both authored Card callbacks passed once, with no authored skips, retries, or flakiness. Each renderer reported 214 passed, 69 skipped, and zero failed, unsupported, incomplete, retried, or flaky tests; those global skips are not passes. The Card CI follow-up is resolved. The local root aggregate limitation above remains, and this is not an all-platform or overall readiness claim.