Repository navigation
Agentic Dropdown: extend contract tests and non-input native coverage - #4414
Merged
Merged
Conversation
Exercise DRP-005 and DRP-011 action/no-op matrices and author DRP-007 recent-selection/fallback native focus cases with honest physical-input capability gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Preserve deferred cases on dropdown-input-tests-held. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
srividyaramas
requested review from
Jason Morse (JasonVMo),
Khalef Hosany (Khalef1) and
Anandraj (mganandraj)
October 28, 2026 22:11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Jason Morse (JasonVMo)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adds unit coverage and non-input native Storybook checks for Dropdown. This PR tests the existing component; additional input-dependent tests remain separate.
Testing
Keyboard, pointer, and wheel input were disabled for that native run. Existing input-dependent skips are not counted as passes. Native macOS results are recorded below; Windows Fabric native qualification is not asserted here.
Input-dependent authored additions are held on a separate branch and are not included here.
The local results and subsequent CI verification are scoped below; no all-platform or overall readiness claim is made. The Windows tooling repair landed separately in #4400 and is not included in this PR.
Native test follow-up
The empty-value assertion now requires exact
nullon macOS Fabric, where the renderer omits empty AXValue, and exact empty string on Paper and UIA. macOS must report a known renderer. A second non-input callback requires the selected option's nonempty native value (Banana) on every renderer, guarding against accidentally accepting missing populated values. Component runtime code is unchanged.At commit
66154c0df2a677a24c3f7e44f356cf8e51e0d4b3, package build, lint, formatting, Storybook type-checking, contract checks, 575 owning-package unit cases, and 8 snapshots passed. Both authored non-input callbacks passed in the exact-head Win32 run; the 8 existing input-dependent callbacks remained explicitly skipped. Combined macOS/Windows bundles passed.CI is now passing on this head, including JS, legacy Win32, both native macOS renderers, and CLA. Downloaded Fabric and Paper reports each confirm both authored callbacks passed, with no authored skips, retries, or flakiness. Other catalog capability skips remain unqualified.
The final cache-cleared combined root aggregate did not pass: an unchanged Storybook sourceConfig subprocess exceeded its existing 10-second limit. The same failure reproduced on the original tooling baseline; focused sourceConfig tests passed. No timeout or concurrency setting was changed. This is not a root-aggregate-green claim.