Repository navigation
Checkbox readiness assessor pilot using existing CI evidence - #4425
srividyaramas wants to merge 9 commits into
Conversation
Add plan.md describing the dedicated Checkbox-first pilot, reviewed mappings, evidence provenance, CI result reuse and optional trusted same-PR publication. Preserve existing source checks and disabled input capabilities; do not activate publishing or include historical generated assessments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Avoid linking a generated report directory before its first publication; no historical snapshot is included in the draft. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
List the App permission, repository variables and secret, rollout trial, managed YAML/report outputs, required-check behavior and rollback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Allow legal repeated titles in unrelated parameterized suites while preserving all package counts and failures. Keep selected Checkbox identities strict and cover both passing and failing duplicate-title cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Keep mapping proposals, owner review and deterministic assessment separate. Mark automation as future work and require full source validation for mapping changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Exercise lowercase, uppercase and mixed-case HTML tag escaping without a misleading filtering regex. Preserve the executable-mode fixture in both the working tree and index, commit without restaging, and assert the committed mode before testing source-digest invalidation. Production logic and evidence checks are unchanged. Validation: scripts build/lint, focused cases and all 233 scripts tests pass. Clean-cache aggregate remains non-green on an unchanged Desktop Driver loopback startup timeout; no deadlines were relaxed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
|
Pushed test-only feedback fixes in 11e8e4f. The JS CI failure came from the executable-mode fixture: its commit helper staged the file a second time, undoing the explicit index mode on Linux. The fixture now aligns physical and indexed executable mode, commits without restaging, and verifies that the committed entry is actually 100755 before testing digest invalidation. The CodeQL test assertion now covers lowercase, uppercase and mixed-case tags. No production, provenance, source-digest or publisher validation logic was relaxed. Validation: scripts build/lint, formatting, focused regressions and the full 233-test/18-suite scripts run passed with no failures or skips. The required clean-cache local aggregate is still NOT green: 105 tasks succeeded before an unchanged Desktop Driver CLI test timed out waiting for loopback /status, leaving other tasks incomplete. No unrelated source or deadlines were changed. Fresh hosted CI is now pending; auto-merge remains subject to required CI, approval and conversation-resolution rules. |
|
Review findings at [P2] Preserve valid partially skipped Jest suites
Jest 29.7 serializes a nonfailed suite containing pending tests as Verification: executed the exact upstream Jest v29.7.0 [P2] Preserve unit retry history before qualifying passes
This conversion discards Jest's Verification: a synthetic bound report with [P2] Include the assertion-bearing native helper in the reviewed fingerprint
The mapped native callback delegates its checked-state assertions to Verification: source inspection and an executed fingerprint probe showed the reader never requested the helper, and changing its supplied content left the digest/current flag unchanged. No native execution was performed. |
Accept Jest focused suite serialization, retain and disqualify retried unit execution, and fingerprint the reviewed native state-assertion helper. Add focused regressions and keep synthetic checkouts aligned. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
|
Addressed the three evidence-review findings in
Validation: 237 scripts tests across 18 suites passed, with no failures or skips; 36 focused regressions, scripts build, lint, formatting and diff checks passed. Replaying the retained actual Jest JSON preserved 812 package passes, 67 Checkbox passes, 25 unmapped cases and zero retries; without a sidecar, provenance correctly remained unverified and readiness insufficient. The required clean-cache local aggregate is not green: 108 tasks succeeded before an unchanged Desktop Driver CLI test timed out waiting for its loopback |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Platforms Impacted
Description of changes
Standalone Checkbox readiness-assessor pilot, ready for review, on its own branch. This is advisory evidence tooling, not a component behavior change, a new control test framework, or automatic maturity promotion.
Start the design review with plan.md. The implementation guide is
scripts/CONTROL-ASSESSMENT.md.Bounded initial coverage: 42 reviewed runtime cases, out of 67 current Checkbox runtime cases; the other 25 are reported as unmapped. One existing native callback is mapped:
toggles native checked state in both directions. Hosted Win32 Storybook disables the physical-input capabilities it needs, so that callback remains skipped there. Compiler-result ingestion, complete native accessibility/focus/layout coverage, visual qualification, readiness policy and other controls are follow-ups.No historical local Checkbox assessment, generated report or SPEC assessment snapshot is included. This PR adds assessor tests, not new Checkbox behavior tests. Collection can run in this PR's normal CI; automated branch publication needs reviewed tooling on
mainand separate maintainer setup.Verification
Assessor fix commit:
6ca79067383ec3db75146705cb858bc38ee7bac1. The three findings in comment 6509427208 are addressed: valid partially skipped Jest suites, preserved/disqualified unit retries, and fingerprinting the reviewed assertion-bearing native helper. All 21 hosted checks passed for that commit, including the requiredPRcheck, CodeQL, all Storybook lanes and the assessor. Latest headfeef01779965043d88767e37e1ba1848914385a0only expandsplan.md; all 21 fresh hosted checks also passed for this latest head. Conditional squash auto-merge remains enabled at the author's request; an approving review is still required.The previous head
11e8e4fa351c5a178f9985fd199ad344aaa091aepassed all 21 hosted checks after the targeted unchanged-head macOS retry. Those results are historical, not validation of the new fix commit.6ca790673)PRcheck. See validated workflow.feef01779)PR. See latest PR workflow. No implementation or workflow changed.6ca790673)assessment.json,ASSESSMENT.mdand proposedSPEC.mdexactly, with verified evidence hashes and no test rerun. This artifact describes the assessor-fix execution, not the later documentation-only head.11e8e4fa3, including JS/Desktop Driver tests, CodeQL, Win32 Storybook and advisory evidence collection. These results do not replace new-head CI. The original CodeQL conversation was resolved only after its fixed instance was verified.yarn lage buildci/statusendpoint. Fail-fast left remaining work incomplete, not proven failed. The separate full 237-test scripts run passed, as did hosted JS/Desktop Driver tests for6ca790673. Hosted success does not erase the local limitation.JasonVMo,Khalef1andmganandraj. Squash auto-merge is enabled, but the effective rules still require thePRcheck, at least one approving review and resolved review conversations. Requesting three reviewers does not require all three approvals. Optional checks remain monitored but are not automatically merge blockers.plan.md.Earlier local Storybook tooling retries also had subprocess/startup timeouts. No StableText source, story selection, readiness checks or test deadlines were changed to suppress failures. Hosted success does not retroactively make failed local runs green.
These validation limitations are disclosed, not waived. Before: no requirement-level assessment of these existing reports. After: an advisory evidence report with explicit gaps; no claim that Checkbox is Production-ready or physically input-qualified. Squash auto-merge waits for the effective branch protections; no review or CI protections are bypassed.
Pull request checklist
This PR has considered (when applicable):
Native keyboard/accessibility qualification is a recorded coverage gap, not a completed checklist item.