feat: prefer resizable Fluent icons - #36705
Draft
Martin Hochel (Hotell) wants to merge 15 commits into
Draft
Conversation
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
| @@ -2,7 +2,7 @@ import * as React from 'react'; | |||
|
|
|||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.customSize+icon+active.normal.chromium.png | 3 | Changed |
| vr-tests-react-components/Avatar Converged.customSize+name+badge.normal.chromium.png | 2 | Changed |
| vr-tests-react-components/Avatar Converged.size+inactive+badge.normal.chromium.png | 13 | Changed |
| vr-tests-react-components/Avatar Converged.size+image+badge.normal.chromium.png | 8 | Changed |
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 8 | Changed |
| vr-tests-react-components/Avatar Converged.size+icon+badge+square.normal.chromium.png | 32 | Changed |
vr-tests-react-components/Card Converged 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Card Converged.orientation.normal.chromium.png | 128 | Changed |
| vr-tests-react-components/Card Converged.CardHeader.normal.chromium.png | 3 | Changed |
| vr-tests-react-components/Card Converged.size.normal.chromium.png | 385 | Changed |
| vr-tests-react-components/Card Converged.appearance - Dark Mode.normal.chromium.png | 518 | Changed |
| vr-tests-react-components/Card Converged.appearance - High Contrast.normal.chromium.png | 674 | Changed |
vr-tests-react-components/Card Converged - Disabled 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Card Converged - Disabled.appearance disabled - Outline.hover.chromium.png | 33 | Changed |
| vr-tests-react-components/Card Converged - Disabled.appearance disabled - Subtle - Dark Mode.hover.chromium.png | 47 | Changed |
vr-tests-react-components/Card Converged - Selectable 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Card Converged - Selectable.appearance selectable - Subtle - High Contrast.selected.chromium.png | 169 | Changed |
| vr-tests-react-components/Card Converged - Selectable.appearance selectable - Subtle.selected.chromium.png | 128 | Changed |
vr-tests-react-components/Checkbox Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Checkbox Converged.disabled+checked.default.chromium.png | 3 | Changed |
| vr-tests-react-components/Checkbox Converged.disabled+mixed.default.chromium.png | 2 | Changed |
| vr-tests-react-components/Checkbox Converged.checked.rest.chromium.png | 7 | Changed |
| vr-tests-react-components/Checkbox Converged.large+mixed.default.chromium.png | 13 | Changed |
| vr-tests-react-components/Checkbox Converged.large+circular+checked.default.chromium.png | 4 | Changed |
| vr-tests-react-components/Checkbox Converged.mixed.rest.chromium.png | 5 | Changed |
vr-tests-react-components/Combobox Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Combobox Converged.With multiselect selection.hover.chromium.png | 13 | Changed |
vr-tests-react-components/Dialog 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Dialog.dialog inside drawer default - High Contrast.chromium.png | 6 | Changed |
| vr-tests-react-components/Dialog.dialog inside drawer dimmed - Dark Mode.chromium.png | 4 | Changed |
| vr-tests-react-components/Dialog.dialog inside drawer dimmed.chromium.png | 5 | Changed |
| vr-tests-react-components/Dialog.title custom action - High Contrast.chromium.png | 34 | Changed |
| vr-tests-react-components/Dialog.title custom action - Dark Mode.chromium.png | 22 | Changed |
| vr-tests-react-components/Dialog.dialog inside drawer transparent - RTL.chromium.png | 9 | Changed |
| vr-tests-react-components/Dialog.title custom action.chromium.png | 25 | Changed |
vr-tests-react-components/Drawer 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.inline drawer separator position start - Dark Mode.chromium.png | 67 | Changed |
| vr-tests-react-components/Drawer.inline drawer separator position start - High Contrast.chromium.png | 99 | Changed |
| vr-tests-react-components/Drawer.inline drawer.chromium.png | 73 | Changed |
| vr-tests-react-components/Drawer.overlay drawer position start - Dark Mode.chromium.png | 67 | Changed |
| vr-tests-react-components/Drawer.overlay drawer position start - High Contrast.chromium.png | 99 | Changed |
| vr-tests-react-components/Drawer.overlay drawer.chromium.png | 73 | Changed |
vr-tests-react-components/Field 13 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Field.Checkbox.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.ProgressBar.default.chromium.png | 20 | Changed |
| vr-tests-react-components/Field.RadioGroup.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.Slider.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.Select.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.Switch.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.SpinButton.default.chromium.png | 25 | Changed |
| vr-tests-react-components/Field.horizontal+longLabel.default.chromium.png | 9 | Changed |
| vr-tests-react-components/Field.validation-error.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.validation-warning.default.chromium.png | 9 | Changed |
| vr-tests-react-components/Field.Textarea.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Field.validation-success.default.chromium.png | 5 | Changed |
| vr-tests-react-components/Field.validationMessageIcon.default.chromium.png | 9 | Changed |
vr-tests-react-components/InfoLabel 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/InfoLabel.default - High Contrast.rest.chromium.png | 36 | Changed |
| vr-tests-react-components/InfoLabel.required.rest.chromium.png | 27 | Changed |
| vr-tests-react-components/InfoLabel.size-small.rest.chromium.png | 8 | Changed |
| vr-tests-react-components/InfoLabel.wrap.rest.chromium.png | 27 | Changed |
| vr-tests-react-components/InfoLabel.sizes -- open.rest.chromium.png | 20 | Changed |
vr-tests-react-components/Menu Converged - selection 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - selection.checkbox - Dark Mode.selected.chromium.png | 5 | Changed |
| vr-tests-react-components/Menu Converged - selection.checkbox.selected.chromium.png | 6 | Changed |
vr-tests-react-components/Menu Converged - selection groups 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - selection groups.default - RTL.selected.chromium.png | 5 | Changed |
vr-tests-react-components/MessageBar 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/MessageBar.Intents - High Contrast.default.chromium.png | 79 | Changed |
| vr-tests-react-components/MessageBar.Multiline Without Actions.default.chromium.png | 51 | Changed |
| vr-tests-react-components/MessageBar.Multiline.default.chromium.png | 51 | Changed |
| vr-tests-react-components/MessageBar.Intents - Dark Mode.default.chromium.png | 36 | Changed |
| vr-tests-react-components/MessageBar.Intents.default.chromium.png | 51 | Changed |
| vr-tests-react-components/MessageBar.Multiline No Actions.default.chromium.png | 51 | Changed |
vr-tests-react-components/Persona Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Persona Converged.basic - Dark Mode.normal.chromium.png | 1 | Changed |
| vr-tests-react-components/Persona Converged.basic - High Contrast.normal.chromium.png | 3 | Changed |
| vr-tests-react-components/Persona Converged.basic.normal.chromium.png | 2 | Changed |
| vr-tests-react-components/Persona Converged.textPosition.normal.chromium.png | 6 | Changed |
| vr-tests-react-components/Persona Converged.textAlignment.normal.chromium.png | 4 | Changed |
| vr-tests-react-components/Persona Converged.size-presence.normal.chromium.png | 6 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 625 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 868 | Changed |
vr-tests-react-components/PresenceBadge Converged - OOF status 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/PresenceBadge Converged - OOF status.default.chromium.png | 94 | Changed |
vr-tests-react-components/PresenceBadge Converged - inverted background 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/PresenceBadge Converged - inverted background.default - High Contrast.default.chromium.png | 373 | Changed |
| vr-tests-react-components/PresenceBadge Converged - inverted background.default - Dark Mode.default.chromium.png | 120 | Changed |
| vr-tests-react-components/PresenceBadge Converged - inverted background.default.default.chromium.png | 192 | Changed |
vr-tests-react-components/PresenceBadge Converged - sizes 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/PresenceBadge Converged - sizes.default - RTL.chromium.png | 6 | Changed |
vr-tests-react-components/PresenceBadge Converged - status 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/PresenceBadge Converged - status.default - RTL.chromium.png | 49 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 59 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 82 | Changed |
vr-tests-react-components/SearchBox Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/SearchBox Converged.Appearance- filled-lighter.hover.chromium.png | 33 | Changed |
| vr-tests-react-components/SearchBox Converged.Disabled, appearance- filled-lighter.hover.chromium.png | 11 | Changed |
| vr-tests-react-components/SearchBox Converged.Disabled, appearance- underline.default.chromium.png | 13 | Changed |
| vr-tests-react-components/SearchBox Converged.Size- large.default.chromium.png | 45 | Changed |
| vr-tests-react-components/SearchBox Converged.Size- small.hover.chromium.png | 18 | Changed |
| vr-tests-react-components/SearchBox Converged.With value.focused.chromium.png | 33 | Changed |
vr-tests-react-components/SpinButton Converged 42 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - Dark Mode.mouseDownIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - Dark Mode.focused.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - Dark Mode.hoverInput.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - Dark Mode.mouseDownDecrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - High Contrast.mouseDownDecrement.chromium.png | 7 | Changed |
| vr-tests-react-components/SpinButton Converged.Appearance- filled-lighter - High Contrast.rest.chromium.png | 8 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound - Dark Mode.focused.chromium.png | 2 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound - Dark Mode.hoverDecrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound - Dark Mode.mouseDownDecrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound - Dark Mode.rest.chromium.png | 2 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound.hoverDecrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound.mouseDownDecrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Max Bound.rest.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound - Dark Mode.focused.chromium.png | 2 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound - Dark Mode.mouseDownIncrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound - Dark Mode.hoverIncrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound.mouseDownIncrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound.rest.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.At Min Bound.hoverIncrement.chromium.png | 3 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - Dark Mode.hoverDecrement.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Disabled.mouseDownDecrement.chromium.png | 1 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - Dark Mode.focused.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - Dark Mode.mouseDownIncrement.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - Dark Mode.mouseDownDecrement.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - High Contrast.mouseDownDecrement.chromium.png | 7 | Changed |
| vr-tests-react-components/SpinButton Converged.Display Value - High Contrast.rest.chromium.png | 8 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-darker.focused.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-darker.hoverIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-lighter.hoverDecrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-lighter.hoverIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-lighter.mouseDownDecrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-lighter.mouseDownIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- filled-lighter.rest.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- underline.hoverIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- underline.hoverDecrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- underline.mouseDownDecrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Invalid- underline.mouseDownIncrement.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Size- small - Dark Mode.default.chromium.png | 4 | Changed |
| vr-tests-react-components/SpinButton Converged.Size- medium (default).default.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Size- small - RTL.default.chromium.png | 5 | Changed |
| vr-tests-react-components/SpinButton Converged.Size- small - High Contrast.default.chromium.png | 8 | Changed |
| vr-tests-react-components/SpinButton Converged.With appearance override.default.chromium.png | 9 | Changed |
vr-tests-react-components/SwatchPicker Converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/SwatchPicker Converged.shape.default.chromium.png | 2 | Changed |
| vr-tests-react-components/SwatchPicker Converged.spacing.default.chromium.png | 2 | Changed |
| vr-tests-react-components/SwatchPicker Converged.size.default.chromium.png | 2 | Changed |
vr-tests-react-components/Table layout table 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Table layout table.multiselect (checked) - neutral - Dark Mode.chromium.png | 22 | Changed |
| vr-tests-react-components/Table layout table.multiselect (checked) - neutral.chromium.png | 34 | Changed |
| vr-tests-react-components/Table layout table.multiselect (mixed) - neutral - Dark Mode.chromium.png | 12 | Changed |
| vr-tests-react-components/Table layout table.multiselect (mixed) - neutral - RTL.chromium.png | 19 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
vr-tests-react-components/Toast 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Toast.Full Toast.Toast visible.chromium.png | 36 | Changed |
| vr-tests-react-components/Toast.Full Toast Inverted - High Contrast.Toast visible.chromium.png | 54 | Changed |
| vr-tests-react-components/Toast.Title Only Inverted - High Contrast.Toast visible.chromium.png | 54 | Changed |
| vr-tests-react-components/Toast.Title Only.Toast visible.chromium.png | 36 | Changed |
| vr-tests-react-components/Toast.Without Subtitle Inverted - High Contrast.Toast visible.chromium.png | 54 | Changed |
| vr-tests-react-components/Toast.Without Subtitle.Toast visible.chromium.png | 36 | Changed |
vr-tests-react-components/Toolbar Converged 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Toolbar Converged.Default.Button Pressed.chromium.png | 51 | Changed |
| vr-tests-react-components/Toolbar Converged.Default.default.chromium.png | 56 | Changed |
| vr-tests-react-components/Toolbar Converged.Far Group.Button Pressed.chromium.png | 28 | Changed |
| vr-tests-react-components/Toolbar Converged.Far Group.default.chromium.png | 33 | Changed |
| vr-tests-react-components/Toolbar Converged.Large.Button Pressed.chromium.png | 59 | Changed |
| vr-tests-react-components/Toolbar Converged.Large.Toggle On.chromium.png | 60 | Changed |
| vr-tests-react-components/Toolbar Converged.Large.default.chromium.png | 66 | Changed |
| vr-tests-react-components/Toolbar Converged.Small.Button Pressed.chromium.png | 51 | Changed |
| vr-tests-react-components/Toolbar Converged.Small.default.chromium.png | 56 | Changed |
| vr-tests-react-components/Toolbar Converged.Transparent.Button Pressed.chromium.png | 50 | Changed |
| vr-tests-react-components/Toolbar Converged.Transparent.default.chromium.png | 57 | Changed |
| vr-tests-react-components/Toolbar Converged.Vertical Button.Button Pressed.chromium.png | 8 | Changed |
| vr-tests-react-components/Toolbar Converged.Vertical Button.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Toolbar Converged.Vertical.Button Pressed.chromium.png | 51 | Changed |
| vr-tests-react-components/Toolbar Converged.Vertical.default.chromium.png | 56 | Changed |
vr-tests-react-components/Tree 34 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Tree.default - Dark Mode.default.chromium.png | 5 | Changed |
| vr-tests-react-components/Tree.actions.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Tree.actions - RTL.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Tree.actions - Dark Mode.default.chromium.png | 5 | Changed |
| vr-tests-react-components/Tree.actions - High Contrast.default.chromium.png | 10 | Changed |
| vr-tests-react-components/Tree.default open tree - Dark Mode.default.chromium.png | 7 | Changed |
| vr-tests-react-components/Tree.default - RTL.default.chromium.png | 5 | Changed |
| vr-tests-react-components/Tree.default - High Contrast.default.chromium.png | 10 | Changed |
| vr-tests-react-components/Tree.default open tree - High Contrast.default.chromium.png | 14 | Changed |
| vr-tests-react-components/Tree.default.default.chromium.png | 6 | Changed |
| vr-tests-react-components/Tree.flat - RTL.default.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.default open tree.default.chromium.png | 8 | Changed |
| vr-tests-react-components/Tree.flat - Dark Mode.default.chromium.png | 9 | Changed |
| vr-tests-react-components/Tree.flat - High Contrast.default.chromium.png | 19 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - Dark Mode.flat tree single selection selected 1.chromium.png | 9 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - Dark Mode.chromium.png | 9 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - High Contrast.flat tree single selection selected 1.chromium.png | 17 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - High Contrast.chromium.png | 19 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - RTL.chromium_1.png | 11 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - RTL.flat tree single selection selected 1.chromium_2.png | 12 | Changed |
| vr-tests-react-components/Tree.flat tree single selection.flat tree single selection selected 1.chromium.png | 12 | Changed |
| vr-tests-react-components/Tree.flat tree single selection.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.layout - Dark Mode.default.chromium.png | 115 | Changed |
| vr-tests-react-components/Tree.flat.default.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.layout - High Contrast.default.chromium.png | 176 | Changed |
| vr-tests-react-components/Tree.persona - High Contrast.default.chromium.png | 23 | Changed |
| vr-tests-react-components/Tree.layout.default.chromium.png | 148 | Changed |
| vr-tests-react-components/Tree.layout - RTL.default.chromium.png | 148 | Changed |
| vr-tests-react-components/Tree.persona - Dark Mode.default.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.persona.default.chromium.png | 29 | Changed |
| vr-tests-react-components/Tree.size - Dark Mode.default.chromium.png | 9 | Changed |
| vr-tests-react-components/Tree.size.default.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.size - RTL.default.chromium.png | 11 | Changed |
| vr-tests-react-components/Tree.size - High Contrast.default.chromium.png | 19 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
There were 562 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previous Behavior
React packages could import fixed-size Fluent icon exports such as
Dismiss20Regular. Sized icon usage was not prevented by lint, SVG-specific style selectors did not cover font icon variants, and the public Storybooks consumed the icon barrel directly.New Behavior
@fluentui/react-icons/prefer-resizableas an error in the shared React ESLint config.fontSizeprops.[data-fui-icon]without increasing specificity.FLUENTUI_ICON_VARIANT=fontsis set, with build-time font subsetting and SVG fallback for unsupported/color icons.Validation:
yarn beachball check, dependency version validation, formatting, and diff checks passed.Bundle size impact
The
@fluentui/react-iconsupgrade initially resolved a second Griffel runtime: repo packages used@griffel/react@1.5.32, while icons required^1.6.1and resolved1.7.7. That duplicated shared Griffel code in every styled package containing icons and produced a repeated ~5.7 kB minified increase. The lockfile now deduplicates@griffel/reactto1.7.7and@griffel/coreto1.21.3.A controlled bundle of the same
WarningFilledicon with one Griffel runtime isolates the remaining icon factory cost:The remaining cost comes from the newer shared SVG factory/runtime: CSP-safe color icon trees, scoped SVG IDs and URL references, color-child resolution,
idPrefixmemoization, shared SVG rendering, anddata-fui-icon.After deduplication, formerly failing fixtures are only 1.8%-4.38% above baseline and below their 10% thresholds. For example, Field changes from 22.311 kB to 23.289 kB (+978 B / 4.38%). The complete styled
react-componentsfixture decreases by 5.959 kB minified / 1.8 kB GZIP because sized icon duplication is removed.react-headless-components-previewdoes not increase: its entire-library fixture remains 241.384 kB minified, and its TagPicker and TeachingPopover fixtures are also unchanged. Only headless stories import the migrated icons; the measured headless library does not.Related Issue(s)