Skip to content

fix(abstractions): keep single value headers to one value when added as a string #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 2 commits into from
Oct 20, 2026
Merged

fix(abstractions): keep single value headers to one value when added as a string #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b04343
fix(abstractions): keep single value headers to one value when added …
unknownhackerworld Oct 20, 2026
83a17c0
Merge branch 'main' into fix/single-value-header-string
baywet Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions packages/abstractions/kiota_abstractions/headers_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,15 @@ def add(self, header_name: str, header_values: Union[str, list[str]]) -> None:
if not header_values: # empty list
return
header_name = header_name.lower()
if isinstance(header_values, list):
if header_name in self.SINGLE_VALUE_HEADERS:
self._headers[header_name] = {header_values[0]}
elif values := self.try_get(header_name):
for header_value in header_values:
values.add(header_value) #type: ignore
else:
self._headers[header_name] = set(header_values)
if not isinstance(header_values, list):
header_values = [header_values]
if header_name in self.SINGLE_VALUE_HEADERS:
self._headers[header_name] = {header_values[0]}
elif values := self.try_get(header_name):
for header_value in header_values:
values.add(header_value) #type: ignore
else:
if values := self.try_get(header_name):
values.add(header_values) #type: ignore
else:
self._headers[header_name] = {header_values}
self._headers[header_name] = set(header_values)

def keys(self) -> list[str]:
"""Gets the header names present in the collection.
Expand Down
15 changes: 12 additions & 3 deletions packages/abstractions/tests/test_request_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ def test_add_single_value_header_to_existing_header():
headers = HeadersCollection()
headers.add("content-type", "value1")
headers.add("content-type", "value2")
assert {"value2"} <= headers.try_get("content-type")
assert {"value2"} <= headers.get("content-type")
assert headers.try_get("content-type") == {"value2"}
assert headers.get("content-type") == {"value2"}
assert headers.contains("content-type")
assert headers.count() == 1

Expand Down Expand Up @@ -180,4 +180,13 @@ def test_adds_headers_from_instance():
assert headers.contains("header3")
assert headers.contains("header4")
assert headers.count() == 4
assert headers.keys() == ["header1", "header2", "header3", "header4"]
assert headers.keys() == ["header1", "header2", "header3", "header4"]
def test_add_all_replaces_single_value_header():
"""Tests that add_all keeps a single value header to one value
"""
headers = HeadersCollection()
headers.add("Content-Type", "application/json")
other = HeadersCollection()
other.add("Content-Type", "text/plain")
headers.add_all(other)
assert headers.get("content-type") == {"text/plain"}
Loading