Repository navigation
fix(http-httpx): export HttpxRequestAdapter and KiotaClientFactory from kiota_http package - #825
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Conversation
…om kiota_http package
|
Contributor
Author
|
I've opened this PR for The PR also fixes a duplicate-word typo in the package README and adds test coverage for the new exports. Whenever convenient, could you please take a look? Thanks for your time! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpxRequestAdapterandKiotaClientFactoryinpackages/http/httpx/kiota_http/__init__.pyand explicitly declare__all__.kiota_httpcontains apy.typedmarker (PEP 561), declaring__all__enables typed consumer applications and IDEs to import directly from the top-level package (from kiota_http import HttpxRequestAdapter, KiotaClientFactory) withoutreportPrivateImportUsageor typing errors.packages/http/httpx/README.md("to to make HTTP requests").packages/http/httpx/tests/test_typing.pyvalidating package exports.