FIX: Separate ODBC wheel payloads by Linux libc family - #798
Merged
Merged
Conversation
Select only matching libc distro trees for manylinux and musllinux wheels. Update release assertions, Conda inventory expectations, existing audit coverage, and packaging documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Jahnvi Thakkar (jahnvi480)
September 18, 2026 06:06
View session
Jahnvi Thakkar (jahnvi480)
enabled auto-merge (squash)
September 18, 2026 06:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The packaging, release validation, Conda audits, tests, and documentation consistently implement the requested libc separation.
Pull request overview
Separates ODBC wheel payloads by Linux libc family while preserving architecture and runtime layout.
Changes:
- Restricts manylinux wheels to glibc trees and musllinux wheels to Alpine/musl.
- Updates release checks and Conda audits for the new inventories.
- Documents libc-specific packaging and legacy audit compatibility.
File summaries
| File | Description |
|---|---|
setup_odbc.py |
Selects libc-specific Linux payloads. |
OneBranchPipelines/stages/build-odbc-all-stage.yml |
Validates wheel contents and rejects foreign libc trees. |
eng/conda_tools/contracts.py |
Updates required Linux driver inventories. |
eng/conda_tools/__main__.py |
Updates audit documentation. |
tests/test_029_bundled_binary_audit.py |
Covers glibc-only and legacy musl payloads. |
PyPI_Description_ODBC.md |
Documents libc-specific wheels. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.1%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.row.py: 77.6%
mssql_python.pybind.ddbc_bindings.cpp: 77.7%
mssql_python.pybind.connection.connection_pool.cpp: 81.8%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.py_type_cache.hpp: 91.6%🔗 Quick Links
|
PR Performance ReportPerformance assessment pending. Waiting for the matching performance run for head |
Copilot started reviewing on behalf of
Jahnvi Thakkar (jahnvi480)
September 18, 2026 07:45
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes cross-platform wheel packaging and release gates, with ARM64 runtime validation limited to archive and ELF inspection.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
Sumit Sarabhai (sumitmsft)
approved these changes
Sep 18, 2026
Copilot started reviewing on behalf of
Jahnvi Thakkar (jahnvi480)
September 18, 2026 09:06
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes consistently enforce libc-specific payload selection and update corresponding release audits and tests.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
gargsaumya
approved these changes
Sep 18, 2026
Copilot started reviewing on behalf of
Jahnvi Thakkar (jahnvi480)
September 18, 2026 10:29
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Separate Linux ODBC wheel payloads by libc family: manylinux wheels retain the glibc-based Debian/Ubuntu, RHEL, and available SUSE variants; musllinux wheels retain only Alpine/musl. Preserve architecture filtering, driver resources, and the existing runtime layout.
Validation completed in Docker with native-built CPython 3.12 extensions on glibc and musl x86-64. Installed-wheel dependency, connection, and cursor/lifecycle checks passed on both (67 passed, 4 skipped per environment), along with live SQL queries, Unicode, DDL/DML, commit, and rollback. Confirmed ODBC libraries loaded from the installed package, not the checkout or system. Existing Conda audit tests passed, and all four Linux wheels passed archive/ELF inspection. Formatting and release-gate checks passed.
ARM64 validation was limited to archive/ELF inspection. The full nonstress/Rust/bulkcopy suite was not run; Rust package downloads were TLS-blocked.