You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep the Node, .NET, Rust, engine, and FFI request-probe surfaces plus the fixes requested during review. Remove unrelated backend-discovery and line-ending changes from the PR.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the stale Bubblewrap contract dependency while retaining the direct mxc_ffi probe dependencies.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document the full Node policy-to-probe flow and explain why request-aware tier probing is specific to ProcessContainer.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
The new Node.js and .NET native ABI paths lack end-to-end integration coverage, and one public description incorrectly attributes capabilities to an executor.
All added managed Probe tests replace RequestProbeInterop, so this generated P/Invoke call is never executed. Add a Windows native integration test that invokes MxcSandbox.Probe() with the built mxc_ffi.dll; otherwise entry-point and ABI drift can ship despite the fake-interoperability tests passing.
Add Windows integration coverage for the Koffi sandbox probe binding
sdk/node/src/bindings/probe.ts:77
The Koffi declaration itself is not exercised by the added tests: they inject either the JSON reader or a fake ProbeNativeFacade, so an incorrect symbol name, pointer level, or error-detail declaration would still pass. Add a Windows integration test that loads the packaged mxc_ffi and calls probeSandboxSupport() through this binding.
Use the supported process authoring intent and the exported platform-support availability field in the request-probe example.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
All added managed tests replace RequestProbeInterop with a fake, so this generated P/Invoke entry point is never invoked. Please add a Windows integration test using the real native unit to cover export generation, marshalling, and packaged-library loading end to end.
Add Windows integration coverage for the real Node native binding
sdk/node/src/bindings/probe.ts:84
The new Node tests inject ProbeNativeFacade, so they never exercise this Koffi symbol lookup or pointer signature against the packaged DLL. A Windows integration test should call probeSandboxSupport() through the real mxc_ffi; otherwise an export/signature or native-asset staging mismatch can ship while every added test passes.
Update architecture docs to mention Node and C# bindings
docs/architecture.md:125
The preceding sentence still says mxc_ffi is used by only the C# SDK, although this PR adds the Node in-process binding shown in the diagram. Update it so the architecture guide reflects both language bindings.
Preserve the owned native pointer for explicit freeing, unload the per-call library handle on every path, restore the top-level probe documentation, and cover real repeated native calls.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft-github-policy-service
Bot
removed
the
Needs-Attention
Adds Windows ProcessContainer request-probe parity to Node.js and .NET through the shared native engine.
probeSandboxSupport(config?)andMxcSandbox.Probe(request?)mxc_ffiin-process, without an executor dependency