You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates all configs in ./tests/configs and ./tests/examples to 1.0, or whichever version is the highest supported version for the feature it's testing (e.g. 0.8 for pre-directional networking). In-line and generated configs in ./tests/scripts get updated, too.
Bump every test config to the highest registered schema version it can
validate against, capped at the current stable 1.0.0. Configs carrying
legacy-only network fields (removed at 0.9) rise to 0.8.0-alpha; the
Windows Sandbox, MicroVM and Hyperlight configs stay at 1.1.0-alpha
because those containment values and the root experimental field exist
only in the development contract.
Add a $schema pointer to post-0.6 configs that lacked one, drop the
now-redundant _09 suffix from environment fixtures and their runner, and
reconcile runner prose that named a schema version the fixture no longer
uses.
Raise the ProcessContainer suite default to 1.0.0 and remove the
enumeratePaths version fallback, pinning the cases that assert a version
gate to the version they are about.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
These fixtures assert shape-based rejections ("unknown field ...") that do
not depend on the schema version, so they can assert against the current
stable contract. The two whose rejection is the version itself stay put:
bwrap_env_08_inherit_rejected.json gates inheritDefaultEnv at 0.8, and
rejected_version_too_old.json is the below-floor case.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The fixture was referenced by no runner, script, or documentation. Schema
floor acceptance is already asserted by the registered-version matrix in
run_processcontainer_lifecycle_test.ps1 and by the contract crate's
per-version tests, so deleting it costs no coverage.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The advertised migration of inline/generated script requests is incomplete. Although the file-backed state-aware fixtures now use 1.0, run_wslc_state_aware_tests.ps1:170 and run_isolation_session_state_aware_tests.ps1:196 still inject 0.9.0-alpha into every inline request without an explicit version, and run_isolation_session_resize_smoke.ps1:212 also remains pinned to 0.9. Update those non-version-gating requests to 1.0 so the backend suites actually exercise the current stable contract consistently.
The version reverts in 0d4e0ab dropped the comma after the version
member, so all five files failed to parse before reaching the version
check.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The IsolationSession fixtures are moved to 1.0, but inline requests still default to 0.9.0-alpha at tests/scripts/run_isolation_session_state_aware_tests.ps1:196, and the generated resize-smoke config still hardcodes 0.9 at run_isolation_session_resize_smoke.ps1:212. Update those generated paths too; otherwise this backend’s suite only partially makes the advertised migration.
File-backed WSLc lifecycle requests now use 1.0, but the inline -Request path still injects 0.9.0-alpha in tests/scripts/run_wslc_state_aware_tests.ps1:170. Consequently, generated state-aware requests remain on the older contract. Update that default to 1.0 so both request paths exercise the intended version.
The IsolationSession and WSLc fixtures moved to 1.0 but the inline
-Request path and the resize-smoke generator still emitted 0.9.0-alpha,
so half of each suite stayed on the older contract. No caller overrides
the default, and every affected case asserts a shape-based outcome, so
the legacy-network rejections still hold at 1.0.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removing the version fallback also dropped the $hasEnumerate assignment
while line 657 still referenced it, so the guard silently evaluated to
$null and no ProcessContainer config emitted filesystem.enumeratePaths.
The predicate is inlined with its original semantics: an empty array
emits nothing.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Three LXC runners assert that their fixtures declare the schema version of
"the current contract", pinned by literal to 0.9. Raising the fixtures to the
new 1.0 stable tripped those guards, which is why LXC was the only failing
suite. Point them at 1.0 so the assertion matches its stated intent.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR updates all configs in
./tests/configsand./tests/examplesto 1.0, or whichever version is the highest supported version for the feature it's testing (e.g. 0.8 for pre-directional networking). In-line and generated configs in./tests/scriptsget updated, too.🔗 References
🔍 Validation
Validated via CI: https://github.com/microsoft/mxc/actions/runs/36792834280. LXC failures in that CI are an oversight and fixed in latest commit. lxc_e2e should be green on this PR in automated tests below.
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow