Repository navigation
Fix benchmark CI with compatible released pytest versions - #312
Merged
Nikhil Navakiran (nikhilNava) merged 2 commits intoOct 28, 2026
Merged
Nikhil Navakiran (nikhilNava) merged 2 commits into
Nikhil Navakiran (nikhilNava) merged 2 commits into
Conversation
Pin pytest 9.1.1 and pytest-benchmark 5.3.0 for both candidate and baseline runs. Pytest 9.2 removes the private _nodeid attribute used by the released benchmark plugin, preventing all benchmark fixtures from initializing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 14661e89-86a3-4afe-a454-263eaeeba021
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Nikhil Navakiran (nikhilNava)
enabled auto-merge (squash)
October 28, 2026 16:34
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the performance-workflow dependency pins, though tests were not run during review and Ubuntu/Python 3.12 validation remains for CI.
No open issues 🎉
What changed in this PR
Pins the performance workflow’s test dependencies to avoid the reported pytest compatibility failure, without changing SDK runtime dependencies or benchmark behavior.
Changes:
- Uses
pytest==9.1.1andpytest-benchmark==5.3.0for both candidate and baseline runs. - Keeps both sides of the benchmark comparison on the same test-tool versions.
No actionable findings. Tests were not run during this review; Ubuntu/Python 3.12 validation remains for CI.
| File | Description |
|---|---|
.github/workflows/performance.yml |
Pins pytest and pytest-benchmark in both installation steps. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 14661e89-86a3-4afe-a454-263eaeeba021
Hector Hernandez (hectorhdzg)
approved these changes
Oct 28, 2026
Nikhil Navakiran (nikhilNava)
merged commit Oct 28, 2026
6009595
into
microsoft:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest==9.1.1andpytest-benchmark==5.3.0in both candidate and baseline installation steps._nodeidattribute still accessed by pytest-benchmark 5.3.0. Without these pins, all four benchmarks fail during fixture setup before any performance measurements run.This is independent of #300 and is based directly on
main.Validation
git diff --checkpassed.