Repository navigation
fix(sync): raise instead of spinning after the driver exits - #3224
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 6, 2026
Merged
Conversation
The dispatcher fiber finishes once the connection to the driver ends. Switching to a dead greenlet returns immediately, so every sync wait loop degenerated into a 100% CPU busy loop that never raised. SyncBase._sync, EventInfo.value and DisposableStub._sync now share one wait helper that raises TargetClosedError when the dispatcher is gone. Reported in microsoft#3187
Yury Semikhatsky (yury-s)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncBase._sync,EventInfo.valueandDisposableStub._syncnow share one wait helper that raisesTargetClosedError("Playwright connection closed")when the dispatcher is gone; the loop is only marked as running while the dispatcher is alive, sostop()and restarting keep working.Reported in #3187.