Repository navigation
fix(evaluate): serialize and parse RegExp values - #3225
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
Based on microsoft#3189 by @FadeHack. Fixes: microsoft#3188
Yury Semikhatsky (yury-s)
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
re.Patternarguments toevaluate()now arrive as a JSRegExpinstead ofundefined, and returnedRegExpvalues come back asre.Patterninstead of the raw protocol dict.recan't compile (e.g. named groups(?<name>…)) falls back to the raw value instead of failing the whole call.Based on #3189 by FadeHack (@FadeHack).
Fixes #3188