fix(mcp): do not ask for roots without the event stream - #42300
fix(mcp): do not ask for roots without the event stream#42300Yury Semikhatsky (yury-s) wants to merge 2 commits into
Conversation
Pretty printing round-tripped the body through JSON.parse/JSON.stringify, which turns every number into a double. Integers beyond Number.MAX_SAFE_INTEGER were silently rounded and number literals were normalized. Keep the source text of each number via JSON.rawJSON, falling back to the old behavior on engines that do not support it. References microsoft#42261
|
If the client advertises |
Test results for "tests 1"19 flaky51183 passed, 1233 skipped Merge workflow run. |
Test results for "MCP"1 failed 8122 passed, 1341 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟢 CI is clear — the one failure is a pre-existing flake
DetailsOverall: This PR changes MCP Pre-existing flake / infra
Not failures
Triaged by the Playwright bot - agent run |
Summary
rootsbut never opens that stream can't be deliveredroots/list, so the request was dropped by the transport and the firsttools/callstalled for the SDK's 60s default timeout.listRoots()when the transport never became bidirectionally ready, instead of sending a request that could only time out.Fixes #42256