Skip to content

fix(cli): add .playwright-cli/ to .gitignore on workspace install - #42318

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42307
Aug 19, 2026
Merged

fix(cli): add .playwright-cli/ to .gitignore on workspace install#42318
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42307

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • playwright-cli install now appends .playwright-cli/ to .gitignore, since traces and storage state saved there can contain credentials.
  • Best-effort: only in a git repo, skipped if the entry is already present, a write failure warns instead of failing the install.

Fixes #42307

@yury-s
Yury Semikhatsky (yury-s) merged commit 644132a into microsoft:main Aug 19, 2026
16 of 17 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the fix-42307 branch August 19, 2026 23:47
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox @mcp-ubuntu-latest-chrome

8122 passed, 1341 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a pre-existing, not caused by this PR

Hi, I'm the Playwright bot and I took a first look at the CI failure here.

The only failing test is mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox on mcp-ubuntu-latest-chrome. That test fails 25 of 25 runs on that exact bot across many unrelated SHAs and PRs — it's a pre-existing environment failure, not something this PR touched.

Details

Overall: this PR only appends .playwright-cli/ to .gitignore in cli-daemon/program.ts (plus a test in cli-misc.spec.ts). Nothing in the diff reaches Chromium sandbox config, so it can't explain the failure.

Pre-existing failure / infra

Nothing here is on this PR to fix — the CI signal is clean for the change.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playwright-cli: install --skills leaves .playwright-cli/ untracked, and traces there can hold credentials

2 participants