test(mcp): cover --sandbox at the config resolution level - #42339
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoAug 20, 2026
Conversation
The e2e test launched chrome-for-testing with the sandbox enabled, which cannot start on Linux, so browser_get_config never returned a config.
Pavel Feldman (pavelfeldman)
approved these changes
Aug 20, 2026
Contributor
Test results for "MCP"1 failed 8128 passed, 1361 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failure here. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsPre-existing flake / infra
Recent history on this bot (oldest → newest, this PR's run is the trailing 🟥): Triaged by the Playwright bot - agent run |
Yury Semikhatsky (yury-s)
merged commit Aug 20, 2026
36f4da0
into
microsoft:main
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sandbox enables the sandboxhas been failing onubuntu-latest - chromesince it landed: it starts an MCP server with--browser=chromium --sandbox, and the server launches the browser eagerly during initialize. Chrome for Testing cannot start sandboxed on Linux (No usable sandbox!), sobrowser_get_configreturned an error instead of a config.config-resolve.spec.tsthat drive real argv throughdecorateMCPCommandintoresolveCLIConfigForMCP, covering--sandbox,--no-sandboxand neither flag without launching a browser.Failing
ubuntu-latest - chromejobs: