fix: preserve err.code in SerializedError cross-process serialization - #42534
Closed
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Closed
fix: preserve err.code in SerializedError cross-process serialization#42534Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Conversation
APIRequestContext errors were losing structured fields (err.code) after cross-process serialization because serializeError only preserved message, stack, and name. This adds code preservation to both serializeError and parseError in both client and server error handling modules. Fixes microsoft#42532
Collaborator
|
Closing in favor of #42562. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIRequestContext errors were losing the
err.codestructured field after cross-process serialization.Root Cause
serializeErrorin bothclient/errors.tsandserver/errors.tsonly preservedmessage,stack, andnamefrom error objects. Thecodefield (common in Node.js network errors likeECONNREFUSED,ECONNRESET, etc.) was silently dropped.Fix
code?: stringto theSerializedError.errortype inpackages/protocol/src/structs.d.tsserializeErrorin both client and server to includee.codewhen presentparseErrorin both client and server to restore thecodefield on the deserialized errorTesting
This fix can be verified with the reproduction script from issue #42532:
Related Issue
Fixes #42532