Skip to content

feat(webkit): roll to r2360 - #42553

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2360
Sep 4, 2026
Merged

feat(webkit): roll to r2360#42553
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2360

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/ca79a2c2817e09a3b5d240f2b08229a9fb4eeaa6. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51331 passed, 1247 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

4 failed
❌ [chromium-page] › page/page-route.spec.ts:277 › should work with custom referer headers @msedge-dev-windows-latest
❌ [chromium-page] › page/page-set-extra-http-headers.spec.ts:65 › should not duplicate referer header @msedge-dev-windows-latest
❌ [webkit-library] › library/browsercontext-storage-state.spec.ts:281 › should round-trip OPFS in a persistent WebKit context @webkit-windows-latest
❌ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak @webkit-macos-15-xlarge

34 flaky ⚠️ [chromium-page] › page/page-screenshot.spec.ts:504 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-ubuntu-22.04`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-macos-latest`
⚠️ [chromium-library] › library/inspector/title.spec.ts:35 › should update primary page URL when original primary closes `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:88 › selector generator › should try to improve role name `@chrome-macos-latest`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › should not print context options method override in nunit if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:412 › reuse launch › should update viewport and media `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:29 › should set the proper viewport size `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/playwright-client.spec.ts:26 › should connect from a page and drive the same browser `@tracing-webkit`
⚠️ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:24 › should print the correct imports and context options `@webkit-windows-latest`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:216 › should keep selected action in view after Show all `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1997 › canvas clipping `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/locator-click.spec.ts:20 › should work Radoslav Kirilov (@smoke)
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

110629 passed, 4739 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 The failures look clear of this PR

This is a WebKit roll (r2359→r2360), so the only product change is the WebKit binary. The four failures in the latest "tests 2" report are all either proven pre-existing flakes or on browsers a WebKit bump can't touch — none point back to this roll.

Details

Overall: 4 failed across the reports. Two are Chromium/Edge tests that a WebKit-only diff can't reach, and two are long-standing WebKit flakes that flip verdict on many unrelated SHAs. Nothing lines up with r2360.

Pre-existing flake / infra

  • [chromium-page] › page/page-route.spec.ts:277 › should work with custom referer headers (@msedge-dev-windows-latest) — pre-existing flake, and on Chromium/Edge, which a WebKit roll can't affect. In the results DB this test fails only on msedge-dev-windows-latest: 41 failures / 362 runs across 35 distinct SHAs and 6 PRs, all unrelated to this PR. Reads like the auto-updating Edge Dev channel, not r2360.

  • [chromium-page] › page/page-set-extra-http-headers.spec.ts:65 › should not duplicate referer header (@msedge-dev-windows-latest) — same msedge-dev-windows-latest bot, same run, another referer-header test; the two failing together on that channel points at the Edge Dev channel rather than anything in this diff. A WebKit binary bump has no path to a Chromium/Edge test. (This exact title has little history in the DB, so I can't stamp it a proven flake, but the roll can't be the cause.)

  • [webkit-library] › library/browsercontext-storage-state.spec.ts:281 › should round-trip OPFS in a persistent WebKit context (@webkit-windows-latest) — pre-existing flake. Strongly bimodal: 28 failures / 89 runs across 28 distinct SHAs and 3 PRs, i.e. it fails ~30% of the time on webkit-windows-latest regardless of the commit. Independently flaky, not introduced by r2360.

  • [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak (@webkit-macos-15-xlarge) — pre-existing flake. 20 failures / 306 runs on webkit-macos-15-xlarge across 20 distinct SHAs and 4 PRs. Known intermittent leak-detector flake, not tied to this roll.

Triaged by the Playwright bot - agent run

@yury-s Yury Semikhatsky (yury-s) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are being fixed in #42570

@yury-s
Yury Semikhatsky (yury-s) merged commit 46cd500 into main Sep 4, 2026
71 of 74 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the roll-into-pw-webkit/2360 branch September 4, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant