fix(mcp): use bundled Chromium for --browser chromium - #42609
Open
Swigler wants to merge 1 commit into
Open
Conversation
`--browser chromium` sets `channel: 'chrome-for-testing'`, but that channel is not registered as a launchable executable in the browser registry — only as a `playwright install` alias. This causes: Chromium distribution 'chrome' is not found at /opt/google/chrome/chrome Drop the channel so Playwright uses the bundled Chromium binary directly, matching the `--browser firefox` pattern. Also add `chromium` to the `--browser` help text which previously omitted it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Swigler please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--browser chromiumcurrently setschannel: 'chrome-for-testing', but that channel is not registered as a launchable executable in the browser registry — it only exists as an alias forplaywright install. This causes a runtime error:Chromium distribution 'chrome' is not found at /opt/google/chrome/chrome--browser firefox)chromiumto the--browserhelp text, which previously omitted itChanges
packages/playwright-core/src/tools/mcp/config.ts— removechannel: 'chrome-for-testing'from the chromium case inresolveBrowserParam()packages/playwright-core/src/tools/mcp/program.ts— addchromiumto valid values in help texttests/mcp/config-resolve.spec.ts— update 3 tests to expect no channel for chromiumTest plan
--browser chromiumlaunches bundled Chromium without errorconfig-resolve.spec.ts)🤖 Generated with Claude Code